jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bennyvw <...@git.apache.org>
Subject [GitHub] jmeter pull request #325: 61544 - Added read, browse and clear as communicat...
Date Fri, 10 Nov 2017 14:15:50 GMT
GitHub user bennyvw opened a pull request:

    https://github.com/apache/jmeter/pull/325

    61544 - Added read, browse and clear as communication styles to JMSSampler

    ## Description
    In JMS Point-to-Point Sampler, besides the standard options for communication style, Request
Only and Request Response, we added options to Read a message, Clear the queue (purge all
messages) and Browse the queue (count number of messages on the queue).
    The property <stringProp> JMSSampler.connectionmode is replaced by an <intProp>
JMSSampler.communicationstyle. This way, multiple languages for the options are supported.
    
    ## Motivation and Context
    It does not solve a problem, but adds some functionality.
    
    ## How Has This Been Tested?
    This change is NOT backwards compatible in that it will not find the intProp communicationStyle
in existing scripts, thus resetting them to 'Clear' option. Hmm, typing this I realize that
'Request Only' might have been the better default option to save existing functionality where
possible.
    
    ## Screenshots (if appropriate):
    
    ## Types of changes
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [X] Breaking change (fix or feature that would cause existing functionality to not work
as expected)
    
    ## Checklist:
    - [X] My code follows the code style of this project.
    - [X] My change requires a change to the documentation.
    - [X] I have updated the documentation accordingly.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bennyvw/jmeter 61544

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/325.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #325
    
----
commit 12a68e3777be4df9b588a2c47994ad059ffe1aa7
Author: DELL_WORK\manfred <manfred.schurhoff@craftsmen.nl>
Date:   2017-09-20T09:33:28Z

    Added jms communication styles (read, browse and clear).

commit 9e6cc05f0a96d8c34de0f53a5a6b78047637cd71
Author: DELL_WORK\manfred <manfred.schurhoff@craftsmen.nl>
Date:   2017-10-31T11:23:20Z

    Updated documentation with Read, Browse, Clear actions for the JMSSampler.
    Renamed connectionMode to communicationStyle.

commit 60c96bffc3dde7aeca669efa09fde6c2325a5486
Author: Manfred M. Schürhoff <m.schurhof@belastingdienst.nl>
Date:   2017-11-07T17:52:04Z

    Fixed compilation issues (removed unused packages).

commit 539b7adf33efba15d936122b2cb56c48997edfd5
Author: Benny van Wijngaarden <b_van_wijngaarden@belastingdienst.nl>
Date:   2017-11-09T15:31:45Z

    Changed formatting for the sake of checkstyle

----


---

Mime
View raw message