jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmouawad <...@git.apache.org>
Subject [GitHub] jmeter issue #341: Test isIgnore after post processor and assertions
Date Fri, 24 Nov 2017 12:23:03 GMT
Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/341
  
    Hi @max3163 ,
    0/ In order to justify the user case, can you illustrate your use case ?
    1/ I think we should add a log in debug level when we ignore a SampleResult
    2/ Could you also add either a JUnit or an integration test (jmx test) that tests different
cases:
    - ignore only in JSR223Sampler
    - ignore only in Assertion
    - ignore only in PostProcessor
    3/ Can you add a comment on the reason for the multiple test ? when reading the code,
I forgot for few minutes the initial intent ,and it was not clear for me. 
    Comment like:
    "setIgnore can be called in Assertion or PostProcessors so test again"
    
    
    Thanks


---

Mime
View raw message