jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bennyvw <...@git.apache.org>
Subject [GitHub] jmeter issue #325: 61544 - Added read, browse and clear as communication sty...
Date Fri, 17 Nov 2017 12:18:52 GMT
Github user bennyvw commented on the issue:

    https://github.com/apache/jmeter/pull/325
  
    Philippe,
    
    In my branch 61544, I did not have the JMS_TESTS files (jmx, xml, csv). I don't know why,
do you?
    
    I added them manually from trunk, even after merging trunk into 61544 I did not have them.
    
    The issues that were introduced in those tests have been solved and I have added tests
for Read, Browse and Clear queue. Because Clear queue did not work on the ActiveMQ queues,
I changed the code slightly.
    
    Just solved the merge conflicts in JMS_TESTS.JMX.
    
    Could you please give it another review?
    
    Regards,
    
    Benny.
    
    > Op 14 november 2017 om 18:24 schreef Philippe M <notifications@github.com>:
    > 
    > 
    >     Hello @bennyvw https://github.com/bennyvw ,
    >     Thanks for updating PR.
    >     It seems the changes have introduced an issue in JMS_TESTS.jmx which is located
in source files on github/svn (only, not in binary) in bin/testfiles:
    >     https://github.com/apache/jmeter/blob/trunk/bin/testfiles/JMS_TESTS.jmx
    > 
    >     To debug the issue, put activemq-all.jar in lib folder and run the test.
    > 
    >     Thanks
    > 
    >     —
    >     You are receiving this because you were mentioned.
    >     Reply to this email directly, view it on GitHub https://github.com/apache/jmeter/pull/325#issuecomment-344333265
, or mute the thread https://github.com/notifications/unsubscribe-auth/Aem4XtE1GQcFri2ghrxZpyxu9skZZjiFks5s2czhgaJpZM4QZnSl
.
    > 
    >      
    > 
    
    
    
    Met vriendelijke groet,
    
    Benny van Wijngaarden.
    Tel. 0629556587http://www.smaragd-it.nl/
    
    
    benny@smaragd-it.nl mailto:benny@smaragd-it.nl



---

Mime
View raw message