jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ham1 <...@git.apache.org>
Subject [GitHub] jmeter pull request #320: HTTPClient 4.5. migration to last APIs / Bugzilla ...
Date Tue, 14 Nov 2017 17:42:18 GMT
Github user ham1 commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/320#discussion_r150891784
  
    --- Diff: src/protocol/http/org/apache/jmeter/protocol/http/control/AuthManager.java ---
    @@ -97,10 +94,33 @@
         private static final boolean DEFAULT_CLEAR_VALUE = false;
     
         /** Decides whether port should be omitted from SPN for kerberos spnego authentication
*/
    -    private static final boolean STRIP_PORT = JMeterUtils.getPropDefault("kerberos.spnego.strip_port",
true);
    +    public static final boolean STRIP_PORT = JMeterUtils.getPropDefault("kerberos.spnego.strip_port",
true);
    +
    +    /** Decides whether port should be omitted from SPN for kerberos spnego authentication
*/
    +    public static final boolean USE_CANONICAL_HOST_NAME = JMeterUtils.getPropDefault("kerberos.spnego.use_canonical_host_name",
true);
     
         public enum Mechanism {
    -        BASIC_DIGEST, KERBEROS
    +        /**
    +         * @deprecated (use {@link Mechanism#BASIC})
    +         */
    +        @Deprecated 
    +        BASIC_DIGEST,
    +        /**
    +         * Basic Auth
    +         */
    +        BASIC, 
    +        /**
    +         * Digest Auth
    +         */
    +        DIGEST, 
    +        /**
    +         * Kerberos Auth
    +         */
    +        KERBEROS
    +    }
    +    
    +    public static void main(String[] args) {
    +        System.out.println(Mechanism.values());
    --- End diff --
    
    Should this be here?


---

Mime
View raw message