jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmouawad <...@git.apache.org>
Subject [GitHub] jmeter pull request #321: [Influxdb] Allow users to add theirs owns tags
Date Tue, 07 Nov 2017 16:59:53 GMT
Github user pmouawad commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/321#discussion_r149436677
  
    --- Diff: src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
---
    @@ -318,6 +335,13 @@ public void setupTest(BackendListenerContext context) throws Exception
{
                     }
                 }
             }
    +        // Check if more fields are filled ( corresponding to user tag )
    +        context.getParameterNamesIterator().forEachRemaining(name->{
    +            if ( !defaultArg.containsKey(name)) {
    +                TAG_USER += "," + AbstractInfluxdbMetricsSender.tagToStringValue(name.trim())
+ "=" + AbstractInfluxdbMetricsSender.tagToStringValue(context.getParameter(name).trim());
    --- End diff --
    
    What if user names his tag the same as an existing attribute ? he can't . If we add a
prefix "TAG_" then I feel it's more clear and avoid conflicts. 
    Also I think this needs more documentation. Feature without documentation is not usable.
We currently lack documentation on InfluxDBBackendListenerClient.
    I think it's a feature that is very interesting and we need users to know it exists and
what it does.


---

Mime
View raw message