jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: [GitHub] jmeter issue #306: Fix to BUG_60156
Date Thu, 07 Sep 2017 21:03:51 GMT
Hi Emilian
AFAIU, it is backward compatible no ?

in AbstractTCPClient.java
<https://github.com/apache/jmeter/pull/306/files#diff-37500fa9c4a5285efe7b85e9bcd62614>,
the new method calls the old one.

Only the subclasses has been modified to implement the new one.

Thanks for reviewing

On Thu, Sep 7, 2017 at 10:58 PM, Emilian Bold <emilian.bold@gmail.com>
wrote:

> I don't know the codebase but why bother marking the old method as
> @Deprecated if you are not making the change backwards compatible?
>
> I see 'return null' in two existing methods while previously those methods
> returned something.
>
> A proper pattern would have been to call read(is, null) or read(is, new
> DummySampleResult()).
>
>
> --emi
>
> On Thu, Sep 7, 2017 at 11:25 PM, pmouawad <git@git.apache.org> wrote:
>
> > Github user pmouawad commented on the issue:
> >
> >     https://github.com/apache/jmeter/pull/306
> >
> >     Hello
> >     Unless there is a NO GO , I'll commit this tomorrow.
> >
> >     Thanks
> >
> >
> > ---
> >
>



-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message