jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FSchumacher <...@git.apache.org>
Subject [GitHub] jmeter pull request #305: Add increase font / decrease font / clear in LogPa...
Date Fri, 25 Aug 2017 18:49:29 GMT
Github user FSchumacher commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/305#discussion_r135326024
  
    --- Diff: src/core/org/apache/jmeter/gui/LoggerPanel.java ---
    @@ -90,6 +91,21 @@ private JTextArea init() { // WARNING: called from ctor so must not
be overridde
                 jSyntaxTextArea.setLineWrap(false);
                 jSyntaxTextArea.setLanguage("text");
                 jSyntaxTextArea.setMargin(new Insets(2, 2, 2, 2)); // space between borders
and text
    +            int fontSize = jSyntaxTextArea.getFont().getSize();
    +            increase = new JMenuItem(String.format(JMeterUtils.getResString("font.increase"),
(fontSize + 1)));
    --- End diff --
    
    The parenthesis around `fontSize + 1` is not needed and should be removed.
    The other scaling used in JMeter uses a multiplication scheme. Perhaps this one should
follow the other one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message