jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1798048 - in /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend: ErrorMetric.java SamplerMetric.java influxdb/InfluxdbBackendListenerClient.java
Date Sat, 10 Jun 2017 12:36:21 GMT
On 9 June 2017 at 11:41, Maxime Chassagneux <mchassagneux@apache.org> wrote:
>>> ==============================================================================

...

>>> ---
>>> jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
>>> (original)
>>> +++
>>> jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
>>> Thu Jun  8 11:53:42 2017
>>> @@ -62,8 +62,11 @@ public class InfluxdbBackendListenerClie
>>>         private static final String TAG_TRANSACTION = ",transaction=";
>>>   -    private static final String TAG_STATUS = ",status=";
>>> +    // As influxdb can't rename tag for now, keep the old name for
>>> backward compatibility
>>> +    private static final String TAG_STATUS = ",statut=";
>>
>>
>> Is this a JMeter mistake? If so, are there so many data sets already, that
>> we can't change it anymore?
>
>
> It's typo error ( fr vs en name )
> The problem is since JMeter 3.2 was released we can't know how many run was
> affected by this typo.
> Just for me, it's about 40Go of influxdb data, about 600 tests.
> If you change the name of a tag here, you create a new one and keep the old
> one.
> And you have to change all yours queries to check two tags
> For me it's better to wait that influxdb implement a rename tag function.

Just leave the value as it is.
But document why it looks odd.

It's vital to be backwards compatible.
If the value does not entirely make sense in English, so be it.
It only needs to be unique for the context.

Mime
View raw message