jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From undera <...@git.apache.org>
Subject [GitHub] jmeter pull request #298: Vary header cache
Date Mon, 19 Jun 2017 20:08:21 GMT
Github user undera commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/298#discussion_r122796161
  
    --- Diff: src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java
---
    @@ -152,22 +197,18 @@ private boolean hasVaryHeader(URLConnection conn) {
          *            result to decide if result is cacheable
          */
         public void saveDetails(HttpResponse method, HTTPSampleResult res) {
    --- End diff --
    
    This method contents looks like duplicate of another `saveDetails`. I'd suggest refactoring
common code into separate method to avoid duplication.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message