jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FSchumacher <...@git.apache.org>
Subject [GitHub] jmeter pull request #296: Bug 61078 - Percentile calculation error
Date Mon, 08 May 2017 17:26:15 GMT
Github user FSchumacher commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/296#discussion_r115304397
  
    --- Diff: src/jorphan/org/apache/jorphan/math/StatCalculator.java ---
    @@ -162,7 +162,7 @@ public T getPercentPoint(double percent) {
             }
     
             // use Math.round () instead of simple (long) to provide correct value rounding
    -        long target = Math.round (count * percent);
    +        long target = Math.round(Math.ceil(count * percent));
    --- End diff --
    
    No need to call `Math.round()` after `Math.ceil()`. A simple cast to `long` would be enough.
But it will probably not hurt, either.
    
    But you should adapt the comment above the line to the new algorithm.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message