jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: Drop HTMLAssertion
Date Sun, 30 Apr 2017 10:33:34 GMT
Hi Felix,
Thanks for your answer.
I never use this feature neither.
I raised this subject while reviewing code.

Regards

On Sun, Apr 30, 2017 at 12:28 PM, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

> Am 19.04.2017 um 22:32 schrieb Philippe Mouawad:
>
>> Hello Felix,
>> What shall we do with this ?
>> Will you be committing your patch ?
>>
> Sorry for the late response.
>
> I can commit the patch, I have even done some further implementation, that
> enables the selection of xhtml, or normal html, BUT I think the parser is
> too lax, to be of real value.
>
> Can you try the current implementation, if it is good enough for your use
> case? I have to admit, that I never really used this feature.
>
> Felix
>
>
> Thanks
>>
>> On Sun, Feb 26, 2017 at 1:28 PM, Philippe Mouawad <
>> philippe.mouawad@gmail.com> wrote:
>>
>> Hello,
>>> As Felix has found a way to do it with reasonable piece of work, I change
>>> my opinion to keep it with following changes:
>>> - Drop JTidy and use JSoup
>>> - or keep JTidy but make JSoup the default
>>>
>>> Regards
>>>
>>> On Sun, Feb 26, 2017 at 1:16 PM, sebb <sebbaz@gmail.com> wrote:
>>>
>>> Please ask the User list whether or not it is being used.
>>>>
>>>> On 26 February 2017 at 12:02, Maxime Chassagneux
>>>> <maxime.chassagneux@gmail.com> wrote:
>>>>
>>>>> +1 too
>>>>>
>>>>> 2017-02-26 10:58 GMT+01:00 Antonio Gomes Rodrigues <ra0077@gmail.com>:
>>>>>
>>>>> +1 to me
>>>>>>
>>>>>> Le 26 févr. 2017 10:17, "Graham Russell" <graham@ham1.co.uk>
a écrit
>>>>>> :
>>>>>>
>>>>>> +1
>>>>>>>
>>>>>>> Sounds good to me too; I only really use the "Response Assertion".
>>>>>>> I think it's a good thing to remove rarely used features to save
>>>>>>> effort reading/testing/maintaining/fixing/supporting these.
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>> Graham
>>>>>>>
>>>>>>> On 25 February 2017 at 22:17, Philippe Mouawad
>>>>>>> <p.mouawad@ubik-ingenierie.com> wrote:
>>>>>>>
>>>>>>>> Hello,
>>>>>>>> I propose to drop HTML Assertion element as it does not support
>>>>>>>>
>>>>>>> HTML5
>>>>
>>>>> and
>>>>>>
>>>>>>> it seems not possible to support it easily :
>>>>>>>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=60774
>>>>>>>>
>>>>>>>> Besides, I am not sure it is really a  useful element.
>>>>>>>>
>>>>>>>> Regards
>>>>>>>> Philippe
>>>>>>>>
>>>>>>>
>>>
>>> --
>>> Cordialement.
>>> Philippe Mouawad.
>>>
>>>
>>>
>>>
>>
>


-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message