Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
MIME-Version: 1.0
In-Reply-To: <CAH9fUpZC2F52csVShMjteUSp+yxxNZQnmNJR9t-rYO=jV3mGjQ@mail.gmail.com>
References: <CAH9fUpZQYDZTR=E0=OMcWvw27iAUjXR2zJS32upbny1WkoGZFA@mail.gmail.com>
 <CAOGo0VZHa1J9LKxHjipvM63LZpa+k=jfoNBz1Sxp9Y5H1s1WhQ@mail.gmail.com>
 <CAH9fUpaBOkNMtmX3MbmsOfYKWLka7atO9j5GmDU9qk-jQCp4Ng@mail.gmail.com>
 <CAOGo0Va5a7zo-W3ov8rfUQ5naab0Vy9p7Bx5ogkf92siQ14Tcg@mail.gmail.com>
 <CAH9fUpZsHyWgokyGipuxP4ugQ9ABbVMtvVpaWXNXaSwyTEB-rQ@mail.gmail.com>
 <CAOGo0VaLgQY=9F29mSfq=yGZtb0VLkKrwA-UQtWiJ1r+EPEOfQ@mail.gmail.com>
 <CAH9fUpb1FoH3HyLGOwx7aw_f_h0FYbpenQ7EucAr-eSwmssfBg@mail.gmail.com>
 <CAOGo0Vb_bzfivg6PGsCvSEC1f3=C1qo=uhb_xSnA=f7x44pTHA@mail.gmail.com> <CAH9fUpZC2F52csVShMjteUSp+yxxNZQnmNJR9t-rYO=jV3mGjQ@mail.gmail.com>
From: sebb <sebbaz@gmail.com>
Date: Tue, 28 Feb 2017 23:23:33 +0000
Message-ID: <CAOGo0Vahbn5hbWLamBixi7=JzTqE26inmOpAg0bZZT_2KvRkCw@mail.gmail.com>
Subject: Re: Release a 3.2
To: dev@jmeter.apache.org
Content-Type: text/plain; charset=UTF-8
archived-at: Tue, 28 Feb 2017 23:23:42 -0000

On 28 February 2017 at 23:15, Philippe Mouawad
<philippe.mouawad@gmail.com> wrote:
> On Tuesday, February 28, 2017, sebb <sebbaz@gmail.com> wrote:
>
>> On 28 February 2017 at 22:40, Philippe Mouawad
>> <philippe.mouawad@gmail.com <javascript:;>> wrote:
>> > On Tue, Feb 28, 2017 at 11:25 PM, sebb <sebbaz@gmail.com <javascript:;>>
>> wrote:
>> >
>> >> On 28 February 2017 at 22:06, Philippe Mouawad
>> >> <philippe.mouawad@gmail.com <javascript:;>> wrote:
>> >> > On Tue, Feb 28, 2017 at 11:01 PM, sebb <sebbaz@gmail.com
>> <javascript:;>> wrote:
>> >> >
>> >> >> On 28 February 2017 at 21:54, Philippe Mouawad
>> >> >> <philippe.mouawad@gmail.com <javascript:;>> wrote:
>> >> >> > Hello,
>> >> >> > We're now at:
>> >> >> >
>> >> >> >    - 48 Enhancements
>> >> >> >    - 31 bug fixes
>> >> >> >
>> >> >> > Sebb has fixed Windows failures on Jenkins
>> >> >> >
>> >> >> >    - Ensure the migrated docs (from PDF) do not contain old "Urban
>> >> >> legends"
>> >> >> >    :-) nor bad practices. Those are the 4 Tutorial links in left
>> >> menu. It
>> >> >> >    would be nice to review them. I've fixed some but not done the
>> full
>> >> >> work
>> >> >> >
>> >> >> > TODO
>> >> >> >
>> >> >> >    - Fill in introduced properties in properties_reference.xml
>> >> >>
>> >> >> Remove obsolete references (e.g. some logging ones ?)
>> >> >>
>> >> >
>> >> > Which ones ?
>> >> > I made the cleanup.
>> >> > Did I forget something ?
>> >> >
>> >> >>
>> >> >> Add logging documentation.
>> >> >>
>> >> > It has been done in properties_reference.xml
>> >>
>> >> There is only some mention of HttpClient logging there.
>> >>
>> >> I could not find any description as to how to set the level for a
>> >> specific JMeter class.
>> >>
>> >
>> > I think this is pretty easy to find on internet knowing we use log4j2 and
>> > slf4j.
>> > But if you think we should add some doc, feel free to do it.
>>
>> Sorry, but that is not good enough.
>> I did not want the hassle of changing the logging. You did want the change.
>
>
> It was an agreement from team. Not only me.

You were the prime mover.

> It's Apache way and boyscout rule :),  it's not enough feel free to improve
> it.
> Search engine results seem good enough for me:
> https://lite.qwant.com/?q=log4j2%20configure%20log
>
>
>
>
>
>> The change was agreed to on the basis that updated documentation was
>> essential.
>>
>> There do not need to be reams of docs, but there should be at least
>> couple of sentences as to how to configure the logging that will be
>> readily understandable to someone used to the old ways.
>
>
> What is the best place for it in your opinion ?

In the user manual (getting started has some references to logging)
with a link from jmeter.properties.

Also needs details in changes.xml for the plugin writers.
Where appropriate that can also point to the user manual.

> I am not saying I'll write it though, as I have contributed already
> important time on this.

Someone has to do it.
If it's not done, then the release should not go ahead.

I did say at the outset that changing logging was going to be a lot of work.

>
>
>>
>> And plugin writers need to be told how to update their plugins.
>>
>> >>
>> >> jmeter.properties used to describe this in some detail.
>> >> The updated description probably does not belong there, but there
>> >> should at least be a pointer to where to find the new information.
>> >>
>> >> >>
>> >> >> Remove remaining references to older logging API.
>> >> >>
>> >> >
>> >> > Where ?
>> >> > I thought I had done it
>> >>
>> >> The string log_level appears in quite a few places.
>> >> AFAIK it is not used in the new scheme
>> >>
>> > I have removed them.
>> > Let me know if I still missed something
>>
>> I don't know if there is anything else.
>> I just happened to notice that reference.
>>
>> Thanks for pointing that
>
>
>> >  Thanks
>> >
>> >>
>> >> >>
>> >> >> >
>> >> >> > DONE
>> >> >> >
>> >> >> >    - If possible add JUnits on the regression introduced in GET
>> with
>> >> no
>> >> >> >    body (see my mail)
>> >> >> >
>> >> >> > DONE
>> >> >> >
>> >> >> >    - Fill in New and Noteworthy section
>> >> >> >
>> >> >> > TODO
>> >> >> >
>> >> >> >
>> >> >> > Are you ok to start a release soon ?
>> >> >> >
>> >> >> > Thanks
>> >> >> >
>> >> >> > Regards
>> >> >> >
>> >> >> > On Tue, Feb 21, 2017 at 4:21 PM, sebb <sebbaz@gmail.com
>> <javascript:;>> wrote:
>> >> >> >
>> >> >> >> I'm seeing some test failures on Windows.
>> >> >> >>
>> >> >> >> I've started to set up a Jenkins build to be able to catch these.
>> >> >> >> (at present the failure mails are sent direct to me)
>> >> >> >>
>> >> >> >> Depending on the cause, the failures need to be fixed before the
>> next
>> >> >> >> release.
>> >> >> >>
>> >> >> >> On 11 February 2017 at 10:22, Philippe Mouawad
>> >> >> >> <philippe.mouawad@gmail.com <javascript:;>> wrote:
>> >> >> >> > Hello,
>> >> >> >> > Since our discussion on "Release a 3.2 ?" , trunk has nicely
>> >> evolved:
>> >> >> >> >
>> >> >> >> >    - 33 Enhancements
>> >> >> >> >    - 25 bug fixes
>> >> >> >> >
>> >> >> >> > I think we can now plan a release.
>> >> >> >> >
>> >> >> >> > I see the following remaining work:
>> >> >> >> >
>> >> >> >> >    - Ensure the migrated docs (from PDF) do not contain old
>> "Urban
>> >> >> >> legends"
>> >> >> >> >    :-) nor bad practices. Those are the 4 Tutorial links in left
>> >> >> menu. It
>> >> >> >> >    would be nice to review them. I've fixed some but not done
>> the
>> >> full
>> >> >> >> work
>> >> >> >> >    - Fill in introduced properties in properties_reference.xml
>> >> >> >> >    - If possible add JUnits on the regression introduced in GET
>> >> with
>> >> >> no
>> >> >> >> >    body (see my mail)
>> >> >> >> >    - Fill in New and Noteworthy section
>> >> >> >> >
>> >> >> >> >
>> >> >> >> >
>> >> >> >> > --
>> >> >> >> > Cordialement.
>> >> >> >> > Philippe Mouawad.
>> >> >> >>
>> >> >> >
>> >> >> >
>> >> >> >
>> >> >> > --
>> >> >> > Cordialement.
>> >> >> > Philippe Mouawad.
>> >> >>
>> >> >
>> >> >
>> >> >
>> >> > --
>> >> > Cordialement.
>> >> > Philippe Mouawad.
>> >>
>> >
>> >
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.