jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmouawad <...@git.apache.org>
Subject [GitHub] jmeter issue #277: Bug 58506 - JMS Point-to-point sampler should offer an as...
Date Tue, 28 Feb 2017 12:27:32 GMT
Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/277
  
    Hello,
    Thank you for your contribution.
    My notes:
    - The class ExtendedQueueRequestor seems to come from existing code as per "This source
code implements specifications defined by the Java Community Process." Are you the author
of this code or not ? If not what is the license of this code ?
    - The code lacks javadoc for  ExtendedQueueRequestor
    - TemporaryQueueExecutor is not used anymore, it should be deprecated
    - The ExtendedQueueRequestor needs to be unit tested. Since we've setup Sonar on repository,
we try to increase test coverage either with JUnit code or Test Plan that allows testing results.
This code should be unit tested using mocks I think
    
    Regards


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message