jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vlsi <...@git.apache.org>
Subject [GitHub] jmeter pull request #254: Feature/bz60589-1 PR for review (logkit to slf4j /...
Date Sun, 05 Feb 2017 13:49:44 GMT
Github user vlsi commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/254#discussion_r99489638
  
    --- Diff: src/core/org/apache/jmeter/gui/GuiPackage.java ---
    @@ -71,10 +72,6 @@
         /** Logging. */
         private static final Logger log = LoggingManager.getLoggerForClass();
     
    -    private static final String NAMING_POLICY_IMPLEMENTATION = 
    -            JMeterUtils.getPropDefault("naming_policy.impl", //$NON-NLS-1$ 
    -                    DefaultTreeNodeNamingPolicy.class.getName());
    -
         /** Singleton instance. */
         private static GuiPackage guiPack;
    --- End diff --
    
    It should be volatile


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message