Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
From: max3163 <git@git.apache.org>
To: dev@jmeter.apache.org
Reply-To: dev@jmeter.apache.org
Message-ID: <git-pr-253-jmeter@git.apache.org>
Subject: [GitHub] jmeter pull request #253: Fix issue with annotation and implement remarks fr...
Content-Type: text/plain
Date: Wed, 18 Jan 2017 19:32:31 +0000 (UTC)
archived-at: Wed, 18 Jan 2017 19:32:33 -0000

GitHub user max3163 opened a pull request:

    https://github.com/apache/jmeter/pull/253

    Fix issue with annotation and implement remarks from last PR #246

    This PR fix a problem we encountered on the annotation metric : Field string have to be quoted and just escape ". 
    
    I have taken your remarks into account and add the timestamp for each metrics and I use now the HttpAsyncClient. I add basic technical configuration too.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/max3163/jmeter Influxdb

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #253
    
----
commit 619717ae7a948cbea15abebf864fc45eabf18330
Author: Maxime Chassagneux <maxime.chassagneux@gmail.com>
Date:   2017-01-18T18:15:56Z

    Fix issue with annotation and implement remarks from last PR
    
    Fix a problem with escape charactere on field ( i.e annotation )
    Add timestamp
    Add HttpAsyncClient 
    Add some technical configurations

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---