Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
MIME-Version: 1.0
In-Reply-To: <CABWbpFeD=xBdmc3FgZkCGTaCHhmzhz+KL1zY9vM4PDM4pLdUqA@mail.gmail.com>
References: <20170116215121.2E3683A0ABA@svn01-us-west.apache.org>
 <CAH9fUpYkgxRwNKFPiueGQzBD1vW8x47JTRCzWshD85HSoY1+2A@mail.gmail.com> <CABWbpFeD=xBdmc3FgZkCGTaCHhmzhz+KL1zY9vM4PDM4pLdUqA@mail.gmail.com>
From: Antonio Gomes Rodrigues <ra0077@gmail.com>
Date: Tue, 24 Jan 2017 22:52:06 +0100
Message-ID: <CABWbpFen51zEVgPnP2RxLNkgWQtkouz8zG1bDsRgqjzU3tjsnw@mail.gmail.com>
Subject: Re: svn commit: r1779114 - in /jmeter/trunk/src/core/org/apache/jmeter:
 report/processor/StatisticsSummaryConsumer.java resources/messages.properties resources/messages_fr.properties
To: dev@jmeter.apache.org
Content-Type: multipart/alternative; boundary=001a114451aac403170546de215a
archived-at: Tue, 24 Jan 2017 21:52:34 -0000

--001a114451aac403170546de215a
Content-Type: text/plain; charset=UTF-8

Hi,

Bugzilla created : https://bz.apache.org/bugzilla/show_bug.cgi?id=60637

Patch provided : see PR 256

If you are ok, I will merge it

Thanks
Antonio

2017-01-17 9:54 GMT+01:00 Antonio Gomes Rodrigues <ra0077@gmail.com>:

> Hi Philippe,
>
> I will take more time to work in it and create a bugzilla with the patch
> to allow us to discuss
>
> Antonio
>
>
> 2017-01-16 23:03 GMT+01:00 Philippe Mouawad <philippe.mouawad@gmail.com>:
>
>> Hello Antonio,
>> I've reverted the change on order as it is not correct.
>> To change order you need to update:
>>
>>    - createResultTitles
>>    - createDataResult
>>    - dashbaord.js (Line 145 => statisticsTable)
>>
>>
>> For such changes, please create a bugzilla before.
>>
>> Thank you
>>
>> On Mon, Jan 16, 2017 at 10:51 PM, <agomes@apache.org> wrote:
>>
>> > Author: agomes
>> > Date: Mon Jan 16 21:51:20 2017
>> > New Revision: 1779114
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1779114&view=rev
>> > Log:
>> > Add unity in statistics report and move min, max colum from the end to
>> > near average time
>> >
>> > Modified:
>> >     jmeter/trunk/src/core/org/apache/jmeter/report/processor/
>> > StatisticsSummaryConsumer.java
>> >     jmeter/trunk/src/core/org/apache/jmeter/resources/messages.
>> properties
>> >     jmeter/trunk/src/core/org/apache/jmeter/resources/
>> > messages_fr.properties
>> >
>> > Modified: jmeter/trunk/src/core/org/apache/jmeter/report/processor/
>> > StatisticsSummaryConsumer.java
>> > URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/
>> > apache/jmeter/report/processor/StatisticsSummaryConsumer.
>> > java?rev=1779114&r1=1779113&r2=1779114&view=diff
>> > ============================================================
>> > ==================
>> > --- jmeter/trunk/src/core/org/apache/jmeter/report/processor/Sta
>> tisticsSummaryConsumer.java
>> > (original)
>> > +++ jmeter/trunk/src/core/org/apache/jmeter/report/processor/Sta
>> tisticsSummaryConsumer.java
>> > Mon Jan 16 21:51:20 2017
>> > @@ -180,6 +180,8 @@ public class StatisticsSummaryConsumer e
>> >              JMeterUtils.getResString("reportgenerator_summary_
>> > statistics_error_percent")));
>> >          titles.addResult(new ValueResultData(
>> >                  JMeterUtils.getResString("reportgenerator_summary_
>> > statistics_mean")));
>> > +        titles.addResult(new ValueResultData(JMeterUtils.
>> > getResString("reportgenerator_summary_statistics_min")));
>> > +        titles.addResult(new ValueResultData(JMeterUtils.
>> > getResString("reportgenerator_summary_statistics_max")));
>> >          titles.addResult(new ValueResultData(
>> >              String.format(
>> >                  JMeterUtils.getResString("reportgenerator_summary_
>> > statistics_percentile_fmt"),
>> > @@ -195,8 +197,6 @@ public class StatisticsSummaryConsumer e
>> >          titles.addResult(new ValueResultData(JMeterUtils.
>> > getResString("reportgenerator_summary_statistics_throughput")));
>> >          titles.addResult(new ValueResultData(JMeterUtils.
>> > getResString("reportgenerator_summary_statistics_kbytes")));
>> >          titles.addResult(new ValueResultData(JMeterUtils.
>> > getResString("reportgenerator_summary_statistics_sent_kbytes")));
>> > -        titles.addResult(new ValueResultData(JMeterUtils.
>> > getResString("reportgenerator_summary_statistics_min")));
>> > -        titles.addResult(new ValueResultData(JMeterUtils.
>> > getResString("reportgenerator_summary_statistics_max")));
>> >          return titles;
>> >      }
>> >
>> >
>> > Modified: jmeter/trunk/src/core/org/apache/jmeter/resources/
>> > messages.properties
>> > URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/
>> > apache/jmeter/resources/messages.properties?rev=
>> > 1779114&r1=1779113&r2=1779114&view=diff
>> > ============================================================
>> > ==================
>> > --- jmeter/trunk/src/core/org/apache/jmeter/resources/messages.
>> properties
>> > (original)
>> > +++ jmeter/trunk/src/core/org/apache/jmeter/resources/messages.
>> properties
>> > Mon Jan 16 21:51:20 2017
>> > @@ -860,10 +860,10 @@ reportgenerator_summary_statistics_error
>> >  reportgenerator_summary_statistics_kbytes=Received KB/sec
>> >  reportgenerator_summary_statistics_sent_kbytes=Sent KB/sec
>> >  reportgenerator_summary_statistics_label=Label
>> > -reportgenerator_summary_statistics_max=Max
>> > -reportgenerator_summary_statistics_mean=Average response time
>> > -reportgenerator_summary_statistics_min=Min
>> > -reportgenerator_summary_statistics_percentile_fmt=%dth pct
>> > +reportgenerator_summary_statistics_max=Max (ms)
>> > +reportgenerator_summary_statistics_mean=Average response time (ms)
>> > +reportgenerator_summary_statistics_min=Min (ms)
>> > +reportgenerator_summary_statistics_percentile_fmt=%dth pct (ms)
>> >  reportgenerator_summary_statistics_throughput=Throughput
>> >  reportgenerator_summary_total=Total
>> >  request_data=Request Data
>> >
>> > Modified: jmeter/trunk/src/core/org/apache/jmeter/resources/
>> > messages_fr.properties
>> > URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/
>> > apache/jmeter/resources/messages_fr.properties?rev=
>> > 1779114&r1=1779113&r2=1779114&view=diff
>> > ============================================================
>> > ==================
>> > --- jmeter/trunk/src/core/org/apache/jmeter/resources/messages_
>> fr.properties
>> > (original)
>> > +++ jmeter/trunk/src/core/org/apache/jmeter/resources/messages_
>> fr.properties
>> > Mon Jan 16 21:51:20 2017
>> > @@ -850,10 +850,10 @@ reportgenerator_summary_statistics_error
>> >  reportgenerator_summary_statistics_kbytes=Ko re\u00e7ues / sec
>> >  reportgenerator_summary_statistics_sent_kbytes=Ko envoy\u00e9s / sec
>> >  reportgenerator_summary_statistics_label=Libell\u00E9
>> > -reportgenerator_summary_statistics_max=Max
>> > -reportgenerator_summary_statistics_mean=Temps moyen
>> > -reportgenerator_summary_statistics_min=Min
>> > -reportgenerator_summary_statistics_percentile_fmt=%d%% centile
>> > +reportgenerator_summary_statistics_max=Max (ms)
>> > +reportgenerator_summary_statistics_mean=Temps moyen (ms)
>> > +reportgenerator_summary_statistics_min=Min (ms)
>> > +reportgenerator_summary_statistics_percentile_fmt=%d%% centile (ms)
>> >  reportgenerator_summary_statistics_throughput=D\u00E9bit
>> >  reportgenerator_summary_total=Total
>> >  request_data=Donn\u00E9e requ\u00EAte
>> >
>> >
>> >
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>>
>
>

--001a114451aac403170546de215a--