Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
From: max3163 <git@git.apache.org>
To: dev@jmeter.apache.org
Reply-To: dev@jmeter.apache.org
References: <git-pr-253-jmeter@git.apache.org>
In-Reply-To: <git-pr-253-jmeter@git.apache.org>
Subject: [GitHub] jmeter issue #253: Fix issue with annotation and implement remarks from last...
Content-Type: text/plain
Message-Id: <20170125175910.724B4DFC12@git1-us-west.apache.org>
Date: Wed, 25 Jan 2017 17:59:10 +0000 (UTC)
archived-at: Wed, 25 Jan 2017 17:59:12 -0000

Github user max3163 commented on the issue:

    https://github.com/apache/jmeter/pull/253
  
    When we flush metrics in the teardownTest method, why the start annotations is not send too ? 
    
    For my remark, I just want to put tags as tag and not as field. The user can put whatever he want too and it's more logic int influxdb sense to have Tags as tag.
    
    I just propose this : 
    
    influxdbMetricsManager.addMetric(EVENTS_FOR_ANNOTATION, TAG_APPLICATION + application + ",title=ApacheJMeter,tags=" + AbstractInfluxdbMetricsSender.tagToStringValue(tags) , 
                            "text=\"" +  AbstractInfluxdbMetricsSender
                            .fieldToStringValue(testTitle + " started") + "\"" );
    
    And add a new parameter call tags as parameter of the backend.
    If you are OK, I will push a new PR in this sense ?
    
    I think it's important to let influxdb index this parameter (only tag are indexed ) and just keep the text value as field.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---