Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
From: max3163 <git@git.apache.org>
To: dev@jmeter.apache.org
Reply-To: dev@jmeter.apache.org
References: <git-pr-253-jmeter@git.apache.org>
In-Reply-To: <git-pr-253-jmeter@git.apache.org>
Subject: [GitHub] jmeter issue #253: Fix issue with annotation and implement remarks from last...
Content-Type: text/plain
Message-Id: <20170121111710.98B21DFB0E@git1-us-west.apache.org>
Date: Sat, 21 Jan 2017 11:17:10 +0000 (UTC)
archived-at: Sat, 21 Jan 2017 11:17:12 -0000

Github user max3163 commented on the issue:

    https://github.com/apache/jmeter/pull/253
  
    Hi,
    
    In your implementation of annotations you add "Tags" as "Field" with the
    same value as the the first tag.
    I don't understand why you want to put this tag as field ?
    If you realy want to have a tags, you could try like this :
    
    events application=foo,tags=START,title=ApacheJMeter text="title test name
    started"
    
    and for the end :
    
    events application=foo,tags=END,title=ApacheJMeter text="title test name
    ended"
    
    
    2017-01-21 11:10 GMT+01:00 Philippe M <notifications@github.com>:
    
    > Hello @max3163 <https://github.com/max3163> ,
    > I merged this PR with following fixes/changes:
    >
    >    - Added more configuration on Async Http Client (Reactor)
    >    - Fixed that End annotation not being sent
    >    - Fixed the label in annotation containing "
    >    - Restored back tags in annotation (is there any reason why you
    >    removed them in last PR ?)
    >    - Isolated properties for this implementation and Graphite one
    >    - Renamed properties.
    >
    > Could you test in your environment and give feedback ?
    > Thank you for your work.
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/jmeter/pull/253#issuecomment-274252427>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/ANMcZkncWH0Es4qwSUeo6Xj3CVDRHnjSks5rUdmugaJpZM4LnS_M>
    > .
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---