jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ham1 <...@git.apache.org>
Subject [GitHub] jmeter pull request #257: Static Analysis Fixes
Date Tue, 24 Jan 2017 21:55:30 GMT
GitHub user ham1 opened a pull request:

    https://github.com/apache/jmeter/pull/257

    Static Analysis Fixes

    Hopefully each commit is small enough to review and apply (and at least some of this is
useful) please let me know if not.
    
    Improvements based largely upon static analysis to improve readability and utilise Java
8 features:
    * Simplify return statements
    * Simplify conditional expressions
    * Utilising lambdas, streams API, computeIfAbsent and method references
    * Removed duplicate throws
    * Removed redundant throws
    * Used ThreadLocal.withIntial
    * Used forEach, addAll and arraycopy to improve readability
    * Replaced StringBuilder with + to improve readability
    * Formatting, spelling and minor refactors
    * Removed some deprecated calls

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ham1/jmeter tidyup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/257.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #257
    
----
commit 5b35976db86d5d024cb1c20eda298bd9b2d9ec99
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-01-22T18:05:47Z

    simplified return statements

commit bf811cb710049165beb8e05620d294ce68068540
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-01-22T18:26:23Z

    simplified conditional expressions

commit fc69fd8939bf9f293637f5b825a457e1b2f7445a
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-01-22T19:00:29Z

    used streams API, computeIfAbsent, foreach, lambdas and method ref to simplify code

commit 11d6d96e26624caddb8163460c4a10e9e58a28f7
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-01-22T19:09:53Z

    Removed duplicate throws

commit fdf652012bbcd4ccaf8bbb1d2562c4d5cbf2ad67
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-01-22T20:42:00Z

    removed redundant throws

commit 3ab11544c79181900fa4dbe3210a00d375b04580
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-01-23T10:05:16Z

    with initial

commit 1ce5c6688e60aba265995808f60072485252ddc7
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-01-23T10:09:00Z

    remove redundant casts/types

commit 1096df55c77ece80687591e4533fea602463b229
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-01-23T10:17:29Z

    simplified foreach, and used addAll and arraycopy functions

commit bcf5edb3f889a8c043d03fc6356cd77e1d020ada
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-01-23T10:22:51Z

    formatting, spelling, remove nulls, minor fixes

commit ac92f1558f1b4f7d0d26c5e0f180ca66d7b25018
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-01-23T10:23:14Z

    replaced StringBuilder with +

commit 6eb862a1df17f6a55e339baf549131ab5fcde8e3
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-01-23T14:57:41Z

    Removed deprecated calls

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message