jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmouawad <...@git.apache.org>
Subject [GitHub] jmeter issue #247: Checks for listener output file existence
Date Wed, 25 Jan 2017 19:20:42 GMT
Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/247
  
    Hello,
    I reviewed this PR and I have some blocker remarks so I didn't merge it:
    - I think code in StandardJMeterEngine  and DistributedRunner is duplicated
    - I wouldn't put any dependency on java.awt in those 2 classes.
    - deleteResultFile should not be static but I don't know how to make it better
    
    Regards
    Philippe


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message