jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FSchumacher <...@git.apache.org>
Subject [GitHub] jmeter pull request #244: Bug60535 error prone boxed primitive constructor
Date Fri, 30 Dec 2016 12:57:43 GMT
Github user FSchumacher commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/244#discussion_r94225584
  
    --- Diff: src/core/org/apache/jmeter/report/processor/Top5ErrorsSummaryData.java ---
    @@ -29,7 +29,7 @@
      */
     public class Top5ErrorsSummaryData {
     
    -    private static final Long ONE = new Long(1);
    +    private static final Long ONE = (long) 1;
    --- End diff --
    
    I think Long.value of(1L) would be a better replacement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message