jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmouawad <...@git.apache.org>
Subject [GitHub] jmeter issue #238: Adds API to create JMeter threads on the fly
Date Thu, 29 Dec 2016 14:44:58 GMT
Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/238
  
    Thanks for contribution.
    I reviewed the patch. It doesn't break current code but I think there may be an issue
in :
    `        Map.Entry<JMeterThread, Thread> entry = allThreads.entrySet().iterator().next();
    `
    
    This may not work in case call happens when all threads of current thread have ended.
allThreads will be empty.
    I think it might be safer to store ListenerNotifier and TestTree in ThreadGroup so that
they can be used in creation without using allThreads.
    I'll create a bugzilla and attach updated patch to it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message