jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From blindio <...@git.apache.org>
Subject [GitHub] jmeter issue #233: Bug 60274
Date Sun, 13 Nov 2016 09:16:32 GMT
Github user blindio commented on the issue:

    https://github.com/apache/jmeter/pull/233
  
    Regarding the run time variable changes, that is a really good point.  I
    will test and consider a solution.
    
    Thank you,
    
    Thorson
    
    On Nov 12, 2016 11:39 PM, "Vladimir Sitnikov" <notifications@github.com>
    wrote:
    
    > *@vlsi* commented on this pull request.
    > ------------------------------
    >
    > In src/components/org/apache/jmeter/control/WeightedDistributionController
    > .java
    > <https://github.com/apache/jmeter/pull/233#pullrequestreview-8310729>:
    >
    > > +     *            the index of the child node
    > +     * @return the child test element
    > +     */
    > +    public TestElement getChildTestElement(int idx) {
    > +        JMeterTreeNode childNode = getChildNode(idx);
    > +        return childNode == null ? null : childNode.getTestElement();
    > +    }
    > +
    > +    /**
    > +     * Gets the cumulative probability.
    > +     *
    > +     * @return the cumulative probability
    > +     */
    > +    public int getCumulativeProbability() {
    > +        // recalculate if reset flag is set
    > +        if (resetCumulativeProbability) {
    >
    > Can you clarify when weight is recalculated?
    > The documentation suggests that weight is recalculated at run-time,
    > however the flag resetCumulativeProbability is reset at design time only.
    > That is it looks like weight distribution would not account for the
    > variable changes in the runtime. Is that the case? Can you make
    > documentation/intention more clear?
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/jmeter/pull/233#pullrequestreview-8310729>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/AGA4ZUhJMiF0gHbHIo8cWemAdoNZEbg-ks5q9r6wgaJpZM4KaUrV>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message