Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
MIME-Version: 1.0
In-Reply-To: <CAB=Je-Gv8vjpnP2AucHci6OM3X70g5Xie7S2cB8oAMqLDbvcjw@mail.gmail.com>
References: <20160903092409.495593A034E@svn01-us-west.apache.org>
 <CAOGo0VYD_=t1uFXvQ74-bE2fdyBWfc8XvqfgX8h8jBt8=41hWg@mail.gmail.com>
 <CAH9fUpYmVxe1XgYZq_NCP8qtjWrPswK8GZGddmdaycCoDY+p=Q@mail.gmail.com>
 <CAOGo0VZwda5Rrx3t=KwPmFKgsV_wsvkd_Er+SoUT06bADO=rcA@mail.gmail.com>
 <CAH9fUparFc7bbKTSE68dP5ZscOSANFp2SxGm5NjTzJv0FyGYUw@mail.gmail.com> <CAB=Je-Gv8vjpnP2AucHci6OM3X70g5Xie7S2cB8oAMqLDbvcjw@mail.gmail.com>
From: Philippe Mouawad <philippe.mouawad@gmail.com>
Date: Tue, 6 Sep 2016 22:04:34 +0200
Message-ID: <CAH9fUpa3b=UK40MoFQayxei8v8eirL_+3wAbyE+aWX7GsnS09w@mail.gmail.com>
Subject: Re: svn commit: r1759062 - in /jmeter/trunk: bin/ src/components/org/apache/jmeter/validation/
 src/core/org/apache/jmeter/gui/action/ xdocs/ xdocs/usermanual/
To: "dev@jmeter.apache.org" <dev@jmeter.apache.org>
Content-Type: multipart/alternative; boundary=94eb2c06654c37b123053bdc4ea4
archived-at: Tue, 06 Sep 2016 20:04:38 -0000

--94eb2c06654c37b123053bdc4ea4
Content-Type: text/plain; charset=UTF-8

On Tuesday, September 6, 2016, Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:

> Philippe>  - Caching with Guava, big discussion, patch refusal, 0 progress
>
> Just for the reference, here's recent discussion on Apache Calcite mailing
> list: "Dropping support for Guava versions earlier than 14"
> https://mail-archives.apache.org/mod_mbox/calcite-dev/
> 201609.mbox/%3CF40BEDBA-7180-4071-8DE9-03EF6439A3B6@apache.org%3E
>
> TL;DR: 18 messages in 3 days discussing how to approach "Guava problem"
>
> Re the CSS patch, I've not seen neither evidence of the problem (e.g.
> thread dumps or whatever) nor comparison (e.g. before vs after).
> So, I would play conservative here and decline adding questionable
> dependencies.

it's true about this particular case.
To be clear, I am not sure the bug is correctly labeled
https://bz.apache.org/bugzilla/show_bug.cgi?id=59934

I don't think there is a race condition in the sense that there would be a
threading bug.
It's just that in case of multiple threads loading the same css, many will
process it then cache while it would be more efficient to have only 1
process and cache and the others use the cache.

Did you try this case with 100 threads doing that ?

>
> If there was a case, I would be interested to fix that.
>
> PS. I prefer to discuss first, commit after even being a committer.
>
> Vladimir
>


-- 
Cordialement.
Philippe Mouawad.

--94eb2c06654c37b123053bdc4ea4--