Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
MIME-Version: 1.0
In-Reply-To: <CAOGo0VZ-qTaBBmkoP_Pwd-N+DdA7rGsMR7N6nG3PwmSMXV8hrg@mail.gmail.com>
References: <20160914201804.145363A09EA@svn01-us-west.apache.org>
 <84995f12-0608-0d44-14ec-08b1ba344d52@internetallee.de> <CAOGo0VZ-qTaBBmkoP_Pwd-N+DdA7rGsMR7N6nG3PwmSMXV8hrg@mail.gmail.com>
From: Antonio Gomes Rodrigues <ra0077@gmail.com>
Date: Sun, 25 Sep 2016 00:03:13 +0200
Message-ID: <CABWbpFcQWhxFSzt_UkfbNCGrCv-xhcrt=78Qs17N-5Z8J8wW8w@mail.gmail.com>
Subject: Re: svn commit: r1760749 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsHTMLFormated.java
To: dev@jmeter.apache.org
Content-Type: multipart/alternative; boundary=001a11c14bc8dfb153053d48109d
archived-at: Sat, 24 Sep 2016 22:03:40 -0000

--001a11c14bc8dfb153053d48109d
Content-Type: text/plain; charset=UTF-8

Hi Sebb,

Thank to the review

How can I fix all the SVN log message I have already made without the right
message?

Antonio

2016-09-23 23:25 GMT+02:00 sebb <sebbaz@gmail.com>:

> On 15 September 2016 at 18:26, Felix Schumacher
> <felix.schumacher@internetallee.de> wrote:
> > Am 14.09.2016 um 22:18 schrieb agomes@apache.org:
> >>
> >> Author: agomes
> >> Date: Wed Sep 14 20:18:03 2016
> >> New Revision: 1760749
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1760749&view=rev
> >> Log:
> >> Add RenderAsHTMLFormated.java file
> >
> > I think we should correct ...[Ff]ormated to ...[Ff]ormatted and normally
> we
> > add the header from the commit messages to the corresponding bugzilla
> > entries.
>
> Also please add the Bugzilla id to the SVN log message.
>
> > Regards,
> >  Felix
> >
> >
> >>
> >> Added:
> >>
> >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> RenderAsHTMLFormated.java
> >>
> >> Added:
> >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> RenderAsHTMLFormated.java
> >> URL:
> >> http://svn.apache.org/viewvc/jmeter/trunk/src/components/
> org/apache/jmeter/visualizers/RenderAsHTMLFormated.java?rev=
> 1760749&view=auto
> >>
> >> ============================================================
> ==================
> >> ---
> >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> RenderAsHTMLFormated.java
> >> (added)
> >> +++
> >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> RenderAsHTMLFormated.java
> >> Wed Sep 14 20:18:03 2016
> >> @@ -0,0 +1,51 @@
> >> +/*
> >> + * Licensed to the Apache Software Foundation (ASF) under one or more
> >> + * contributor license agreements.  See the NOTICE file distributed
> with
> >> + * this work for additional information regarding copyright ownership.
> >> + * The ASF licenses this file to You under the Apache License, Version
> >> 2.0
> >> + * (the "License"); you may not use this file except in compliance with
> >> + * the License.  You may obtain a copy of the License at
> >> + *
> >> + *   http://www.apache.org/licenses/LICENSE-2.0
> >> + *
> >> + * Unless required by applicable law or agreed to in writing, software
> >> + * distributed  under the  License is distributed on an "AS IS" BASIS,
> >> + * WITHOUT  WARRANTIES OR CONDITIONS  OF ANY KIND, either  express  or
> >> + * implied.
> >> + *
> >> + * See the License for the specific language governing permissions and
> >> + * limitations under the License.
> >> + */
> >> +
> >> +package org.apache.jmeter.visualizers;
> >> +
> >> +import org.apache.jmeter.samplers.SampleResult;
> >> +import org.apache.jmeter.util.JMeterUtils;
> >> +import org.jsoup.Jsoup;
> >> +
> >> +public class RenderAsHTMLFormated extends SamplerResultTab implements
> >> ResultRenderer {
> >> +
> >> +    /** {@inheritDoc} */
> >> +    @Override
> >> +    public void renderResult(SampleResult sampleResult) {
> >> +        String response =
> >> ViewResultsFullVisualizer.getResponseAsString(sampleResult);
> >> +        showHTMLFormatedResponse(response);
> >> +    }
> >> +
> >> +    private void showHTMLFormatedResponse(String response) {
> >> +        results.setContentType("text/plain"); // $NON-NLS-1$
> >> +        results.setText(response == null ? "" :
> >> Jsoup.parse(response).html()); // $NON-NLS-1$
> >> +        results.setCaretPosition(0);
> >> +        resultsScrollPane.setViewportView(results);
> >> +        // Bug 55111 - Refresh JEditor pane size depending on the
> >> presence or absence of scrollbars
> >> +
> >> resultsScrollPane.setPreferredSize(resultsScrollPane.getMinimumSize());
> >> +        results.revalidate();
> >> +    }
> >> +
> >> +    /** {@inheritDoc} */
> >> +    @Override
> >> +    public String toString() {
> >> +        return
> >> JMeterUtils.getResString("view_results_render_html_formated"); //
> >> $NON-NLS-1$
> >> +    }
> >> +
> >> +}
> >>
> >>
> >
>

--001a11c14bc8dfb153053d48109d--