jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milamberspace <...@git.apache.org>
Subject [GitHub] jmeter pull request #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Date Fri, 05 Aug 2016 05:45:49 GMT
Github user milamberspace commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/223#discussion_r73644512
  
    --- Diff: src/core/org/apache/jmeter/util/JSR223TestElement.java ---
    @@ -86,11 +88,16 @@ public JSR223TestElement() {
         }
     
         protected ScriptEngine getScriptEngine() throws ScriptException {
    -        final String lang = getScriptLanguage();
    +        String lang = getScriptLanguage();
    +        
    +        if (lang.isEmpty()) {
    +            lang = defaultScriptLanguage;
    +            log.warn("Script language has not been chosen on the UI, the script will
be interpreted as a groovy script");
    +        }
     
             ScriptEngine scriptEngine = getInstance().getEngineByName(lang);
             if (scriptEngine == null) {
    --- End diff --
    
    The scriptEngine will be never null if groovy become the default language. This (if and
exception below) must be changes. 
    Perhaps put here the test (if lang is undefine then log warn "interpret as groovy script")


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message