jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Schumacher <>
Subject Re: [GitHub] jmeter pull request #216: re-use pattern when possible
Date Mon, 18 Jul 2016 20:30:28 GMT

Am 18. Juli 2016 22:25:53 MESZ, schrieb PascalSchumacher <>:
>Github user PascalSchumacher commented on a diff in the pull request:
>--- Diff:
>    @@ -147,6 +148,8 @@
>private static final int TIME_TO_LIVE =
>JMeterUtils.getPropDefault("httpclient4.time_to_live", 2000);
>private static final String CONTEXT_METRICS = "jmeter_metrics"; // TODO
>hack for metrics related to HTTPCLIENT-1081, to be removed later
>    +    
>+    private static final Pattern PORT_PATTERN =
>    --- End diff --
>I'm sure you are aware of this, but let's mention it anyway: Pattern is
>not thread-safe, so you have to be careful with static instances. (Of
>course I lack the necessary knowledge of jmeter to judge wether it's
>save to reuse the pattern in these classes.)

According to it is

Why do you think it is not? 

>If your project is set up for it, you can reply to this email and have
>reply appear on GitHub as well. If your project does not have this
>enabled and wishes so, or if the feature is enabled but not working,
>contact infrastructure at or file a JIRA
>with INFRA.

View raw message