jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Schumacher <felix.schumac...@internetallee.de>
Subject Re: [GitHub] jmeter pull request #216: re-use pattern when possible
Date Mon, 18 Jul 2016 20:30:28 GMT


Am 18. Juli 2016 22:25:53 MESZ, schrieb PascalSchumacher <git@git.apache.org>:
>Github user PascalSchumacher commented on a diff in the pull request:
>
>    https://github.com/apache/jmeter/pull/216#discussion_r71222330
>  
>--- Diff:
>src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
>---
>    @@ -147,6 +148,8 @@
>private static final int TIME_TO_LIVE =
>JMeterUtils.getPropDefault("httpclient4.time_to_live", 2000);
>     
>private static final String CONTEXT_METRICS = "jmeter_metrics"; // TODO
>hack for metrics related to HTTPCLIENT-1081, to be removed later
>    +    
>+    private static final Pattern PORT_PATTERN =
>Pattern.compile("^\\d+$");
>    --- End diff --
>    
>I'm sure you are aware of this, but let's mention it anyway: Pattern is
>not thread-safe, so you have to be careful with static instances. (Of
>course I lack the necessary knowledge of jmeter to judge wether it's
>save to reuse the pattern in these classes.)

According to https://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html it is
threadsafe.

Why do you think it is not? 

>
>
>---
>If your project is set up for it, you can reply to this email and have
>your
>reply appear on GitHub as well. If your project does not have this
>feature
>enabled and wishes so, or if the feature is enabled but not working,
>please
>contact infrastructure at infrastructure@apache.org or file a JIRA
>ticket
>with INFRA.
>---


Mime
View raw message