jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ham1 <...@git.apache.org>
Subject [GitHub] jmeter pull request: Used multi-catch, enhanced for loops, contain...
Date Sat, 07 May 2016 18:42:21 GMT
Github user ham1 commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/174#discussion_r62420814
  
    --- Diff: src/core/org/apache/jmeter/reporters/ResultCollector.java ---
    @@ -386,16 +384,14 @@ public void loadExistingFile() {
                                 SaveService.loadTestResults(bufferedInputStream,
                                         new ResultCollectorHelper(this, visualizer));
                                 parsedOK = true;
    -                        } catch (ConversionException e) {
    -                            log.warn("Failed to load "+filename+" using XStream. Error
was: "+e);
                             } catch (Exception e) {
    -                            log.warn("Failed to load "+filename+" using XStream. Error
was: "+e);
    +                            log.warn("Failed to load " + filename + " using XStream.
Error was: " + e);
    --- End diff --
    
    Probably, however that would mean changing the rest in this file for consistency. I left
it as it was as my intention for this PR was for Java 7 related changes i.e. multi-catch (in
this case removing duplicate code and 'fixing' whitespace while there).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message