Return-Path: X-Original-To: apmail-jmeter-dev-archive@minotaur.apache.org Delivered-To: apmail-jmeter-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C5A7D1839F for ; Mon, 18 Apr 2016 21:31:08 +0000 (UTC) Received: (qmail 43664 invoked by uid 500); 18 Apr 2016 21:31:03 -0000 Delivered-To: apmail-jmeter-dev-archive@jmeter.apache.org Received: (qmail 43633 invoked by uid 500); 18 Apr 2016 21:31:03 -0000 Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jmeter.apache.org Delivered-To: mailing list dev@jmeter.apache.org Received: (qmail 43617 invoked by uid 99); 18 Apr 2016 21:31:03 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Apr 2016 21:31:03 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 50CCEDFD43; Mon, 18 Apr 2016 21:31:03 +0000 (UTC) From: ra0077 To: dev@jmeter.apache.org Reply-To: dev@jmeter.apache.org Message-ID: Subject: [GitHub] jmeter pull request: Bug59351_BetterErrorMessageInIncludeControlle... Content-Type: text/plain Date: Mon, 18 Apr 2016 21:31:03 +0000 (UTC) GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/202 Bug59351_BetterErrorMessageInIncludeControllerForFileNotFound Hi, When JMeter try to load a file which don't exist in InludeController we have this log 2016/04/18 22:22:12 INFO - jmeter.services.FileServer: Set new base='C:\Util\0_JMX' 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -- try to load included module: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -Attempting to read it from: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 ERROR - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -- try to load included module: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -Attempting to read it from: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 ERROR - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:34:12 WARN - jmeter.control.IncludeController: Unexpected error java.io.IOException: loadIncludedElements -failed for: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx and C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx at org.apache.jmeter.control.IncludeController.loadIncludedElements(IncludeController.java:135) at org.apache.jmeter.control.IncludeController.resolveReplacementSubTree(IncludeController.java:111) at org.apache.jmeter.control.IncludeController.clone(IncludeController.java:64) at org.apache.jmeter.gui.action.CheckDirty.addNode(CheckDirty.java:162) and a popup box with useless message to user (see attached screenshot) I propose to have a more usefull log and error message. Ant to check that the file can be read Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59351_BetterErrorMessageInIncludeControllerForFileNotFound Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/202.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #202 ---- commit aef98d759f25745201f338c0cb73cdac6a929ae9 Author: ra0077 Date: 2016-04-18T21:30:04Z Bug59351_BetterErrorMessageInIncludeControllerForFileNotFound Hi, When JMeter try to load a file which don't exist in InludeController we have this log 2016/04/18 22:22:12 INFO - jmeter.services.FileServer: Set new base='C:\Util\0_JMX' 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -- try to load included module: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -Attempting to read it from: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 ERROR - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -- try to load included module: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -Attempting to read it from: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 ERROR - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:34:12 WARN - jmeter.control.IncludeController: Unexpected error java.io.IOException: loadIncludedElements -failed for: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx and C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx at org.apache.jmeter.control.IncludeController.loadIncludedElements(IncludeController.java:135) at org.apache.jmeter.control.IncludeController.resolveReplacementSubTree(IncludeController.java:111) at org.apache.jmeter.control.IncludeController.clone(IncludeController.java:64) at org.apache.jmeter.gui.action.CheckDirty.addNode(CheckDirty.java:162) and a popup box with useless message to user (see attached screenshot) I propose to have a more usefull log and error message. Ant to check that the file can be read Antonio ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---