Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CAH9fUpYFqouonjC_-TSpxppzrG6W=pb9ok2ck9UBPPVAzdoRyg@mail.gmail.com>
References: <572137BE.7010405@apache.org>
	<CAH9fUpYFqouonjC_-TSpxppzrG6W=pb9ok2ck9UBPPVAzdoRyg@mail.gmail.com>
Date: Thu, 28 Apr 2016 21:51:03 +0200
Message-ID: 
 <CAH9fUpZ-qpwLC9Rj4mg0U4ecjL0o1NaNnkk0Xxp++e43pniVcw@mail.gmail.com>
Subject: Re: [VOTE] Release JMeter 3.0 RC3
From: Philippe Mouawad <philippe.mouawad@gmail.com>
To: "dev@jmeter.apache.org" <dev@jmeter.apache.org>
Content-Type: multipart/alternative; boundary=94eb2c08fd20a20bce053190d857

--94eb2c08fd20a20bce053190d857
Content-Type: text/plain; charset=UTF-8

Ok,
I have the fix.

The issue is that in testEnded, we trigger a Thread that runs ListenToTest,
but we don't create it as NON Daemon thread.

So when the ClientJMeterEngine.tidyRMI(log); runs, it interrupts the last
NON Daemon thread (RMI reaper) which makes the JVM exit.

So the fix is just to make it NON Daemon:

        public void testEnded(String host) {
            long now=System.currentTimeMillis();
            log.info("Finished remote host: " + host + " ("+now+")");
            if (started.decrementAndGet() <= 0) {
                Thread stopSoon = new Thread(this);
// FIX
                stopSoon.setDaemon(false);
// END OF FIX
                stopSoon.start();
            }
        }


Shall we RC4 or go ahead like this ?

Regards
Philippe


On Thu, Apr 28, 2016 at 8:18 PM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:

> Thanks for the RM.
> Except for the issue with distributed mode it seems ok .
>
> But I reckon I am a bit annoyed as report generation will only work in
> standalone mode.
> Even if it was an existing bug it has more impact now.
>
> Is it regular that a thread.interrupt exits the jVM ?
> Looks to me as a java bug no ?
> Do you all reproduce this issue or is it only a Mac osx issue ?
>
> Thanks
> Regards
>
>
> On Thursday, April 28, 2016, Milamber <milamber@apache.org> wrote:
>
>> Hello,
>>
>> The third release candidate for JMeter 3.0 (r1741338) has been prepared,
>> and your votes are solicited.
>>
>> This release brings a lot of new features (over 100) and fixes many bugs
>> (60). The JMeter's logo and the JMeter's website have been refreshed.
>>
>> Please, test this release candidate (with load tests and/or functional
>> tests) using Java 7/8 on Linux/Windows/Mac OS, especially on the changes.
>> The feedback are welcome.
>>
>> You can read the New and Noteworthy section with some screenshots to
>> illustrate improvements and full list of changes at:
>> http://home.apache.org/~milamber/jmeter-3.0RC3/docs/changes.html
>>
>> JMeter is a Java desktop application designed to load test functional
>> behavior and measure performance. The current version is targeted at Java
>> 7+.
>>
>> Download - Archives/hashes/sigs:
>>
>> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC3/
>> (dist revision r13443)
>>
>> RAT report:
>>
>>
>> http://home.apache.org/~milamber/jmeter-3.0RC3/dist/rat-report-jmeter-3.0RC3.txt
>>
>> MD5 hashes of archives for this vote:
>>
>> 35c5e7798f602336c5bbcd8981804443 *apache-jmeter-3.0.tgz
>> 9b8e01f005cfd56b92ae0c828bac54d4 *apache-jmeter-3.0.zip
>> 88f03da71a9c90d21441e9139813afa6 *apache-jmeter-3.0_src.zip
>> e6d7d1ed92830537cd06eb1748a07287 *apache-jmeter-3.0_src.tgz
>>
>> Site Docs are here:
>> http://home.apache.org/~milamber/jmeter-3.0RC3/docs/
>>
>> Maven staging repository is accessible here:
>>
>> https://repository.apache.org/content/repositories/orgapachejmeter-1008/org/apache/jmeter/
>>
>> Tag:
>> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC3/
>>
>> Keys are here:
>> https://www.apache.org/dist/jmeter/KEYS
>>
>> N.B.
>> To download the dependencies: "ant download_jars"
>>
>> To create the jars and test JMeter: "ant package test".
>>
>> JMeter 3.0 requires Java 7 or later to run.
>>
>> Some known issues and incompatible changes are listed on changes page.
>> http://home.apache.org/~milamber/jmeter-3.0RC3/docs/changes.html
>>
>>
>> All feedback and vote are welcome.
>>
>> [  ] +1  I support this release
>> [  ] +0  I am OK with this release
>> [  ] -0   OK, but....
>> [  ] -1   I do not support this release (please indicate why)
>>
>> The vote will remain open for at least 72 hours.
>>
>> The PMC members please indicate the mention "(binding)" with your vote.
>>
>>
>> Note: If the vote passes, the intention is to release the archive files
>> and rename the RC tag as the release tag.
>>
>> Thanks in advance!
>>
>> Milamber
>>
>>
>>
>>
>>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
>


-- 
Cordialement.
Philippe Mouawad.

--94eb2c08fd20a20bce053190d857--