Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CAH9fUpa0SdaD=daZ6oodC813r98hNnd8T8qPygYOLRtJ-EFnYA@mail.gmail.com>
References: 
 <CAFn=E_7qUi=3dzsn2HAL-VnL+Pr6OKrr8NEef+F_kcvfPBZgyQ@mail.gmail.com>
 <CAH9fUpYqh7Wp9nSO=uhb1SKtSRfdQrjAUQUprpHJwuH+kpCMtw@mail.gmail.com>
 <CAFn=E_6mcEyMQap-4=ctX4UMXp8gt6B2E5JWmM1an=VShXP=9Q@mail.gmail.com>
 <CAH9fUpa0SdaD=daZ6oodC813r98hNnd8T8qPygYOLRtJ-EFnYA@mail.gmail.com>
From: Pierre Roudier <pjw.roudier@gmail.com>
Date: Thu, 14 Apr 2016 10:55:59 +0200
Message-ID: 
 <CAFn=E_6ha6U+j7DT1zJO0Jz9Egk5AYjW=OH4JiqhV0y2U5FCXw@mail.gmail.com>
Subject: Re: Listing directory content with the FTPSampler
To: dev@jmeter.apache.org
Content-Type: multipart/alternative; boundary=047d7bd91a728818eb05306e122a

--047d7bd91a728818eb05306e122a
Content-Type: text/plain; charset=UTF-8

Hi

The current version is already backward compatible; it's quite easy to
implement. I'll make sure the new one remains compatible.

Before I start the dev, what are the guidelines regarding JMeter UI? I'd
like to know what screen size is targeted.
The only doc fairly related I found is
https://wiki.apache.org/jmeter/DeveloperManual/JMeterGuiBasics but it
doesn't address this topic.

Pierre


On Wed, Apr 13, 2016 at 2:00 PM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:

> Hi,
> It should be backward compatible, ie reading a 3.0 plan in 3.1 should be
> possible and the correct selection should be made.
> I didn't have a deep look at this but I think it is possible.
>
> Regards
>
>
> On Wednesday, April 13, 2016, Pierre Roudier <pjw.roudier@gmail.com>
> wrote:
>
> > Thanks for your feedback.
> > My first approach has been to minimize the impact on the existing UI but
> if
> > the community is ready for some changes, I'd be happy to replace the
> radio
> > buttons with a select box.
> >
> > Best Regards
> > Pierre
> >
> > On Tue, Apr 12, 2016 at 2:42 PM, Philippe Mouawad <
> > philippe.mouawad@gmail.com <javascript:;>> wrote:
> >
> > > Thank you for your contribution proposal.
> > > It appears rather clean but I wonder if a select box instead of radio
> > > button might not be a better option for extending Sampler.
> > > If we want to add another command it will be easier as it wont require
> > gui
> > > change and place won't be a problem.
> > > If you can make the changes I'll be happy to merge it after release of
> > 3.0
> > > Regards
> > > Philippe
> > > On Saturday, April 9, 2016, Pierre ROUDIER <pjw.roudier@gmail.com
> > <javascript:;>> wrote:
> > >
> > > > Hello,
> > > >
> > > > I needed the ability to send the LIST FTP command from the FTPSampler
> > > for a
> > > > test scenario at work. So I forked the project on GitHub and gave it
> a
> > > go.
> > > > The result can be seen here:
> > > >
> > > >
> > >
> >
> https://github.com/proudier/jmeter/commit/ff103720ee0d5f9b43dc54f56eb5778757bed936
> > > >
> > > > Key aspects:
> > > > - As the original FTPSampler used a boolean "Upload" flag , I had to
> > > > refactor some code to allow for a "switch compliant" architecture.
> > > > Consequently, the FTPSampler.upload property had to be replaced with
> a
> > > > FTPSampler.command.
> > > > - The sampler understands both properties, so that unmodified .jmx
> can
> > be
> > > > ran as before.
> > > > - The conversion from the legacy property to the new one is performed
> > > upon
> > > > loading in the GUI. Thus, after saving, the .jmx file hold the proper
> > > > property.
> > > >
> > > > I ran the following tests:
> > > > - ant checkstyle => OK
> > > > - ant test  => OK
> > > > - and I've been using the whole thing at my work place for 3 weeks
> > > >
> > > > I'd be happy to hear your comments and make the necessary adjustments
> > > > before making the pull-request.
> > > >
> > > > Best regards
> > > > Pierre
> > > >
> > >
> > >
> > > --
> > > Cordialement.
> > > Philippe Mouawad.
> > >
> >
>
>
> --
> Cordialement.
> Philippe Mouawad.
>

--047d7bd91a728818eb05306e122a--