Return-Path: X-Original-To: apmail-jmeter-dev-archive@minotaur.apache.org Delivered-To: apmail-jmeter-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 26F02198E6 for ; Tue, 12 Apr 2016 13:17:57 +0000 (UTC) Received: (qmail 92915 invoked by uid 500); 12 Apr 2016 13:17:57 -0000 Delivered-To: apmail-jmeter-dev-archive@jmeter.apache.org Received: (qmail 92890 invoked by uid 500); 12 Apr 2016 13:17:57 -0000 Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jmeter.apache.org Delivered-To: mailing list dev@jmeter.apache.org Received: (qmail 92876 invoked by uid 99); 12 Apr 2016 13:17:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Apr 2016 13:17:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E641F180183 for ; Tue, 12 Apr 2016 13:17:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.429 X-Spam-Level: X-Spam-Status: No, score=0.429 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=ya.ru Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id xlW1TQ_KjNDd for ; Tue, 12 Apr 2016 13:17:53 +0000 (UTC) Received: from forward10m.cmail.yandex.net (forward10m.cmail.yandex.net [5.255.216.203]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id BD15A5F232 for ; Tue, 12 Apr 2016 13:17:52 +0000 (UTC) Received: from smtp1m.mail.yandex.net (smtp1m.mail.yandex.net [IPv6:2a02:6b8:0:2519::121]) by forward10m.cmail.yandex.net (Yandex) with ESMTP id 0E91521DD3 for ; Tue, 12 Apr 2016 16:17:45 +0300 (MSK) Received: from smtp1m.mail.yandex.net (localhost [127.0.0.1]) by smtp1m.mail.yandex.net (Yandex) with ESMTP id D11C26740182 for ; Tue, 12 Apr 2016 16:17:45 +0300 (MSK) Received: by smtp1m.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id ggVP7updvf-HjbWYbTR; Tue, 12 Apr 2016 16:17:45 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ya.ru; s=mail; t=1460467065; bh=VLCDkRgLOHmXfFHkCKuXj6etp+RAK4E581B20oKKwV0=; h=Subject:To:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=aIeGdpb06qG/w1Y8GItTlOGWmtAPV/j6kjSkhmNvuDBuy+8EgU/kO0AEIhbh/iH+p KyhvXB0Gar+ctooCjfxLrByiPHeydJ43BF3iP2U+ZrSpZ4NuX/J/51knjZ290ZfrNt n6EuvwQsrg4/v/32VlbNKymF/WPxMjY2iVeu2Zmw= Authentication-Results: smtp1m.mail.yandex.net; dkim=pass header.i=@ya.ru X-Yandex-ForeignMX: NL X-Yandex-Suid-Status: 1 0 Subject: Re: Plugin market? (was: 3rd party jars - current and proposed) To: dev@jmeter.apache.org References: <57091964.30704@ya.ru> <570954EF.60601@ya.ru> <57095CDE.2010204@ya.ru> <57096657.9030306@ya.ru> From: Andrey Pokhilko Message-ID: <570CF579.3060800@ya.ru> Date: Tue, 12 Apr 2016 16:17:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Yes, you can keep discussing the idea of plugins market as part of the core, that's not an issue. Users would benefit from having it as part of the core. I'm not sure what you mean by "commercial plugin hoster". Most of the plugins are downloaded from maven repositories. The plugins list is downloaded from jmeter-plugins.org which is open source and non-commercial. I've chosen the way of implementing it rather than discussing because some things are so obvious that they need no discussion. It is still not too late to share your feedback, because it is in beta testing stage. For example, following your feedback I've removed the "BlazeMeter Set"... Andrey Pokhilko On 04/12/2016 03:53 PM, Philippe Mouawad wrote: > On Saturday, April 9, 2016, Andrey Pokhilko wrote: > >> I speak about unknown element. > ok > >> The plugins market needs no discussion, I'm 70% into implementing it. > > In my opinion it should have been discussed but you are free to implement > it in "your" project, it appears it will rely on a commercial 3rd pArty as > plugin hoster. > > We are of course free to discuss it within the project and choose a > different way to do it. > I still believe it must be in Core JMeter. > > > >> Andrey Pokhilko >> >> On 04/09/2016 11:05 PM, Philippe Mouawad wrote: >>> On Saturday, April 9, 2016, Andrey Pokhilko > >> wrote: >>>> Accepting bets on the discussion result... I'll better spend the time >>>> writing code for "plugins market" than to have long discussions. Sorry, >>>> that's my personal issues. >>>> >>>> For me you got the feature idea right, message transferred, so what to >>>> discuss :)? >>> are you speaking about the plugin market or unknown element ? >>> >>> if first one, what can be discussed is the format and way of working. >>> If unknown element, then it's true dev can start >>> >>>> Andrey Pokhilko >>>> >>>> On 04/09/2016 10:21 PM, Philippe Mouawad wrote: >>>>> what's the problem, let's discuss this in core >>>>> >>>>> On Saturday, April 9, 2016, Andrey Pokhilko >> > >>>> wrote: >>>>>> So you got the idea right. Unfortunately, this can't be done as >>>>>> third-party plugin, it requires core change. >>>>>> >>>>>> Andrey Pokhilko >>>>>> >>>>>> On 04/09/2016 10:02 PM, Philippe Mouawad wrote: >>>>>>> On Saturday, April 9, 2016, Andrey Pokhilko > >>>> > >>>>>> wrote: >>>>>>>> In fact, I'm already working on "plugins repository" feature. So it >>>> will >>>>>>>> be available soon. >>>>>>>> >>>>>>>> What could be improved in JMeter regarding situation of unknown >> plugin >>>>>>>> in test plan is to still show the test plan, putting some "Unknown >>>> Class >>>>>>>> Element" at the place of unknown classes. That would allow reviewing >>>>>>>> these elements in UI which would be easier than monstrous error >>>> message >>>>>>>> currently shown. Although I'd keep the message. Also the plan with >>>>>>>> "Unknown Element" present wouldn't be available for running. Well, >>>>>>>> another arguable idea from me, tangential to the subject at hand, so >>>>>>>> nevermind :). >>>>>>>> >>>>>>>> I find this idea interesting. >>>>>>> The ideal situation for me would be: >>>>>>> - open the plan >>>>>>> - Show as you propose unknown element for the missing class with >> maybe >>>>>> the >>>>>>> stacktrace in the gui of this unknown element >>>>>>> - when saving the plan, the missing class is not changed so the >>>> initial >>>>>>> plan is not corrupt >>>>>>> >>>>>>> >>>>>>> >>>>>>>> Andrey Pokhilko >>>>>>>> >>>>>>>> On 04/09/2016 11:56 AM, sebb wrote: >>>>>>>>> On 8 April 2016 at 22:40, Vladimir Sitnikov < >>>>>> sitnikov.vladimir@gmail.com >> >>>>>>>> > wrote: >>>>>>>>>> Philippe> The idea was interesting because it makes things rather >>>>>>>> simple. >>>>>>>>>> What if we take a step back and consider some kind of "JMeter >> Plugin >>>>>>>> Market"? >>>>>>>>> This is tangential to the subject at hand. >>>>>>>>> >>>>>>>>>> For instance: >>>>>>>>>> 1) Search & install plugins from within JMeter UI >>>>>>>>> -1; that would add unnecessary classes to memory. >>>>>>>>> >>>>>>>>> However it could be stand-alone. >>>>>>>>> >>>>>>>>> Though I'm not sure how much work it would save compared with the >>>>>>>>> effort of creating and maintaining it. That sounds like a good 3rd >>>>>>>>> party project; it seems OT for JMeter. >>>>>>>>> >>>>>>>>>> 2) If loading a test plan that references not yet installed >> plugins, >>>>>>>>>> JMeter would be able to suggest installing the required ones >>>>>>>>> JMeter only knows what classes the test plan cannot find. >>>>>>>>> Who is going to maintain the database of plugin locations and their >>>>>>>> classes? >>>>>>>>> Who is going to vet the plugins? >>>>>>>>> >>>>>>>>> However it might be possible to improve the error messages that are >>>>>>>>> produced when test classes cannot be found. >>>>>>>>> >>>>>>>>>> Vladimir >>