jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [GitHub] jmeter pull request: Used multi-catch, enhanced for loops, contain...
Date Tue, 19 Apr 2016 22:41:50 GMT
On 19 April 2016 at 22:40, vlsi <git@git.apache.org> wrote:
> Github user vlsi commented on a diff in the pull request:
>
>     https://github.com/apache/jmeter/pull/174#discussion_r60316883
>
>     --- Diff: src/core/org/apache/jmeter/reporters/ResultCollector.java ---
>     @@ -386,16 +384,14 @@ public void loadExistingFile() {
>                                  SaveService.loadTestResults(bufferedInputStream,
>                                          new ResultCollectorHelper(this, visualizer));
>                                  parsedOK = true;
>     -                        } catch (ConversionException e) {
>     -                            log.warn("Failed to load "+filename+" using XStream.
Error was: "+e);
>                              } catch (Exception e) {
>     -                            log.warn("Failed to load "+filename+" using XStream.
Error was: "+e);
>     +                            log.warn("Failed to load " + filename + " using XStream.
Error was: " + e);
>     --- End diff --
>
>     I think comma should be used to log exception stacktrace, shouldn't it?

Yes, but is a stack trace necessary here?
So long as it's obvious what the problem is and how to fix it without
the stack trace, that just adds noise.

>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---

Mime
View raw message