jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ra0077 <...@git.apache.org>
Subject [GitHub] jmeter pull request: Bug59294_BetterPercentileLabelv3
Date Sat, 09 Apr 2016 07:37:50 GMT
Github user ra0077 commented on the pull request:

    https://github.com/apache/jmeter/pull/187#issuecomment-207734589
  
    Hi Vladimir,
    
    Thanks to your tips and advices
    
    I have juste make a rebase to have "clean properties files" and I have
    modify again the 2 files
    
    Antonio
    
    <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=oa-2200-c>
    Garanti
    sans virus. www.avast.com
    <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=oa-2200-c>
    <#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
    
    2016-04-09 9:32 GMT+02:00 Vladimir Sitnikov <notifications@github.com>:
    
    > @ra0077 <https://github.com/ra0077>, thanks for the PRs, however could
    > you please try reusing the PRs next time?
    >
    > Regarding "the right properties files", can you please clarify if you have
    > to perform additional steps to make properties file "sane"?
    >
    > Regarding reuse:
    >
    > You could force push new commit to your Bug59294_BetterPercentileLabel
    > branch, that would update #186 <https://github.com/apache/jmeter/pull/186>
    > .
    >
    > In simple case (like #186 <https://github.com/apache/jmeter/pull/186>)
    > "close PR + send new PR" does little difference from "update PR with new
    > contents", however keeping the same URL, comment thread, conversation, etc,
    > helps.
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/jmeter/pull/187#issuecomment-207733923>
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message