jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vlsi <...@git.apache.org>
Subject [GitHub] jmeter pull request: Separate thirdparty dirs
Date Mon, 04 Apr 2016 12:11:55 GMT
Github user vlsi commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/181#discussion_r58365976
  
    --- Diff: src/core/org/apache/jmeter/NewDriver.java ---
    @@ -85,9 +86,22 @@
     
             // Add standard jar locations to initial classpath
             StringBuilder classpath = new StringBuilder();
    -        File[] libDirs = new File[] { new File(jmDir + File.separator + "lib"),// $NON-NLS-1$
$NON-NLS-2$
    -                new File(jmDir + File.separator + "lib" + File.separator + "ext"),//
$NON-NLS-1$ $NON-NLS-2$
    -                new File(jmDir + File.separator + "lib" + File.separator + "junit")};//
$NON-NLS-1$ $NON-NLS-2$
    +        List<File> libDirs = new LinkedList<>();
    +        libDirs.add(new File(jmDir + File.separator + "lib")); // $NON-NLS-1$ $NON-NLS-2$
    +        libDirs.add(new File(jmDir + File.separator + "lib" + File.separator + "ext"));
// $NON-NLS-1$ $NON-NLS-2$
    +        libDirs.add(new File(jmDir + File.separator + "lib" + File.separator + "junit"));
// $NON-NLS-1$ $NON-NLS-2$
    +
    +        // add thirdparty extensions to classpath
    +        File thirdpartyRoot = new File(jmDir + File.separator + "lib" + File.separator
+ "3rdparty");
    +        File[] thirdpartyDirs = thirdpartyRoot.listFiles(new FilenameFilter() {
    +            @Override
    +            public boolean accept(File dir, String name) {
    +                return new File(dir, name).isDirectory();
    --- End diff --
    
    Please correct to `FileFilter.accept(File pathname)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message