Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CAH9fUpbbUq1H8Y46aP3ThHsanJrd7uvaxKnCggR=ExXAeWO0-g@mail.gmail.com>
References: <20160321181704.3D7023A027B@svn01-us-west.apache.org>
	<CAH9fUpaNAPfk2eMqX+zayebih5+0PeEeduRvbHSkK8mxsn+YmA@mail.gmail.com>
	<DC8C5700-8B50-49AE-9A63-B4CBD8224711@internetallee.de>
	<CAH9fUpbbUq1H8Y46aP3ThHsanJrd7uvaxKnCggR=ExXAeWO0-g@mail.gmail.com>
Date: Tue, 22 Mar 2016 20:05:48 +0000
Message-ID: 
 <CAOGo0Var9PeOPebgpa+QGGoBcY3wxbea+eV9yiOB6H+U96emUA@mail.gmail.com>
Subject: Re: svn commit: r1736072 - in /jmeter/trunk:
 src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java
 xdocs/changes.xml
From: sebb <sebbaz@gmail.com>
To: dev@jmeter.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

What do we do for other samplers if the connect fails?

Do we document the behaviour?

is the value supposed to be the time to connect even if connect fails?

On 22 March 2016 at 19:32, Philippe Mouawad <philippe.mouawad@gmail.com> wr=
ote:
> In fact I don't know :-)
>
> In case of exception, connectEnd won't be called so for example, if issue
> is due to timeout, value will not be equal to timeout.
> Should we put it in a try/finally arount getSocket ?
> Thanks
>
> On Tue, Mar 22, 2016 at 8:29 PM, Felix Schumacher <
> felix.schumacher@internetallee.de> wrote:
>
>>
>>
>> Am 22. M=C3=A4rz 2016 20:22:22 MEZ, schrieb Philippe Mouawad <
>> philippe.mouawad@gmail.com>:
>> >Hi Felix,
>> >Do you think it is ok in case of Connection error ?
>>
>> Yes,  that is why I put connectEnd there. But feel free to place it
>> somewhere else. I wouldn't be angry.
>>
>> Regards,
>> Felix
>>
>> >
>> >Thank you
>> >Regards
>> >
>> >On Mon, Mar 21, 2016 at 7:17 PM, <fschumacher@apache.org> wrote:
>> >
>> >> Author: fschumacher
>> >> Date: Mon Mar 21 18:17:03 2016
>> >> New Revision: 1736072
>> >>
>> >> URL: http://svn.apache.org/viewvc?rev=3D1736072&view=3Drev
>> >> Log:
>> >> TCP Sampler: Set connect time in sampler when connection is
>> >established.
>> >>
>> >> Bugzilla Id: 59205
>> >>
>> >> Modified:
>> >>
>> >>
>>
>> >jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TC=
PSampler.java
>> >>     jmeter/trunk/xdocs/changes.xml
>> >>
>> >> Modified:
>> >>
>>
>> >jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TC=
PSampler.java
>> >> URL:
>> >>
>> >
>> http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/tcp/org/apache/jm=
eter/protocol/tcp/sampler/TCPSampler.java?rev=3D1736072&r1=3D1736071&r2=3D1=
736072&view=3Ddiff
>> >>
>> >>
>>
>> >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>> >> ---
>> >>
>>
>> >jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TC=
PSampler.java
>> >> (original)
>> >> +++
>> >>
>>
>> >jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TC=
PSampler.java
>> >> Mon Mar 21 18:17:03 2016
>> >> @@ -393,6 +393,7 @@ public class TCPSampler extends Abstract
>> >>          res.sampleStart();
>> >>          try {
>> >>              Socket sock =3D getSocket(socketKey);
>> >> +            res.connectEnd();
>> >>              if (sock =3D=3D null) {
>> >>                  res.setResponseCode("500"); //$NON-NLS-1$
>> >>                  res.setResponseMessage(getError());
>> >>
>> >> Modified: jmeter/trunk/xdocs/changes.xml
>> >> URL:
>> >>
>> >
>> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=3D173607=
2&r1=3D1736071&r2=3D1736072&view=3Ddiff
>> >>
>> >>
>>
>> >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>> >> --- jmeter/trunk/xdocs/changes.xml (original)
>> >> +++ jmeter/trunk/xdocs/changes.xml Mon Mar 21 18:17:03 2016
>> >> @@ -171,6 +171,7 @@ Summary
>> >>      <li><bug>58300</bug> Make existing Java Samplers implement
>> >> Interruptible</li>
>> >>      <li><bug>58160</bug>JMS Publisher : reload file content if file
>> >name
>> >> changes. Based partly on a patch contributed by Maxime Chassagneux
>> >> (maxime.chassagneux at gmail.com)</li>
>> >>      <li><bug>58786</bug>JDBC Sampler : Replace Excalibur DataSource
>> >by
>> >> more up to date library commons-dbcp2</li>
>> >> +    <li><bug>59205</bug>TCP Sampler: Set connect time in sampler
>> >when
>> >> connection is established.</li>
>> >>  </ul>
>> >>
>> >>  <h3>Controllers</h3>
>> >>
>> >>
>> >>
>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.