Return-Path: X-Original-To: apmail-jmeter-dev-archive@minotaur.apache.org Delivered-To: apmail-jmeter-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B6AF919349 for ; Sun, 27 Mar 2016 19:51:58 +0000 (UTC) Received: (qmail 44521 invoked by uid 500); 27 Mar 2016 19:51:58 -0000 Delivered-To: apmail-jmeter-dev-archive@jmeter.apache.org Received: (qmail 44485 invoked by uid 500); 27 Mar 2016 19:51:58 -0000 Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jmeter.apache.org Delivered-To: mailing list dev@jmeter.apache.org Received: (qmail 44472 invoked by uid 99); 27 Mar 2016 19:51:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Mar 2016 19:51:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D7304C021F for ; Sun, 27 Mar 2016 19:51:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.179 X-Spam-Level: * X-Spam-Status: No, score=1.179 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id gA31VbcCraBN for ; Sun, 27 Mar 2016 19:51:56 +0000 (UTC) Received: from mail-qk0-f182.google.com (mail-qk0-f182.google.com [209.85.220.182]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id 6DB2C5F23C for ; Sun, 27 Mar 2016 19:51:56 +0000 (UTC) Received: by mail-qk0-f182.google.com with SMTP id i4so47925249qkc.3 for ; Sun, 27 Mar 2016 12:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to; bh=3VAxJ9576gpHzNIj2oZAzUSo8hqmnMkyL9FRbEPJHbU=; b=z4i0B3PjWBgefLNuJ7eV80Glr9Oy+8NptcoTlu3JFzMqbkdlo6qOkIBgHPSzbebhGe JZN2BHNbaHA7AXbwVK+8iPe5oaMzLxvOpWM46U5xg8MFLev/4WrA5DzGxoB5EL04Ru0X tidgKZpWgDmAcTonFl0zIp82gjD5HiJSl9Mp4bEnL+IGvIDqF78QrJgbm8sKYECT3gxF wGkZIyc+izG2Az2bLQUlCz8J9vL/gUG78+5kHEFENKDxM/rbWgajYMCzk6CNMKaKhKcg FpLdovtks4WvlYTXajd9B/un7aG57K/mj5nL06ycEDQdaniRGDg4kWxc4ffGNUMfvHY3 TFmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to; bh=3VAxJ9576gpHzNIj2oZAzUSo8hqmnMkyL9FRbEPJHbU=; b=cejLcDVJyQoNFIjNJPHFvEC14ucAI0kxv5XXA3YoB/aeCRl0URe0aUOSE0u8PEvUix i3xzdRxcXTYF0dJJWtAWkEbM6f8QxdaHE/3QbMcncWHfzErCe85kLPNySlKVi4Fvt2qZ 6HsdBWWb279ZI54GBIJx8aDqiRItDtoqONY5vxISj7CnUUsaf0tFsUBuNZge86CqpLvc hU/UFn20nJ9R/bysTx1DQpp+MC1QPwYSAMQK0ZZ0AbCqiPjZ7bZ2K5qJUBLgpNA/l0j/ oo1r3LONuh3EDrzGP/NKpQUJQzaEmQFybPLO2CPIBvOH01xEZAHg5oAXOUDNM0Gz18wW GZvw== X-Gm-Message-State: AD7BkJIeVi9KclxSKbTmROHgEg0Y/S47RLgUjJB9tj11N87iQ+XUjOgxxeWrL+Z8gFNtJinrxMt7rD1JMIZoRA== MIME-Version: 1.0 X-Received: by 10.55.74.9 with SMTP id x9mr31410343qka.81.1459108315699; Sun, 27 Mar 2016 12:51:55 -0700 (PDT) Received: by 10.55.116.65 with HTTP; Sun, 27 Mar 2016 12:51:55 -0700 (PDT) In-Reply-To: <56F51C18.6080502@apache.org> References: <56F51C18.6080502@apache.org> Date: Sun, 27 Mar 2016 21:51:55 +0200 Message-ID: Subject: Re: Drop some properties and merge icon.properties with icons-toolbar.properties From: Philippe Mouawad To: "dev@jmeter.apache.org" Content-Type: multipart/alternative; boundary=001a11488a78d89ffd052f0d208c --001a11488a78d89ffd052f0d208c Content-Type: text/plain; charset=UTF-8 I removed this part within commit : http://svn.apache.org/viewvc?rev=1736812&view=rev On Fri, Mar 25, 2016 at 12:08 PM, Milamber wrote: > > What about the Options menu > Toolbar? > > > On 25/03/2016 07:45, Philippe Mouawad wrote: > >> Hi, >> Ok I will drop : >> - jmeter.toolbar.display >> - jmeter.errorscounter.display >> >> And leave this one but not exposed in jmeter.properties: >> - jmeter.icons >> >> Regards >> >> On Thu, Mar 24, 2016 at 11:43 PM, sebb wrote: >> >> On 24 March 2016 at 21:20, Philippe Mouawad >>> wrote: >>> >>>> Hello, >>>> I have asked on mailing list and the answers (3 only) I got all say >>>> they >>>> are not used. >>>> Shall I drop them ? >>>> >>> I would prefer to keep jmeter.icons >>> It's useful for trialling new sets. >>> >>> Regards >>>> >>>> On Sat, Mar 12, 2016 at 1:52 PM, Philippe Mouawad < >>>> philippe.mouawad@gmail.com> wrote: >>>> >>>> I've sent a mail to users mailing list >>>>> >>>>> On Sat, Mar 12, 2016 at 1:44 PM, sebb wrote: >>>>> >>>>> On 11 March 2016 at 20:10, Philippe Mouawad < >>>>>> >>>>> philippe.mouawad@gmail.com> >>> >>>> wrote: >>>>>> >>>>>>> Hello, >>>>>>> I suggest we drop the following: >>>>>>> >>>>>>> - jmeter.toolbar.display >>>>>>> - jmeter.errorscounter.display >>>>>>> - jmeter.icons >>>>>>> >>>>>>> Because: >>>>>>> >>>>>>> 1. Why would somebody not want the toolbar ? >>>>>>> >>>>>> Have you asked the users? >>>>>> >>>>>> 2. Why would somebody not want the errors counter ? >>>>>>> >>>>>> Ditto. >>>>>> >>>>>> 3. Do we really need to provide customization of icons ? New ones >>>>>>> >>>>>> are >>> >>>> nice, that's it >>>>>>> >>>>>> They may not suit all tastes or all types of eyesight; why drop the >>>>>> >>>>> code? >>> >>>> Shouldn't we also merge: >>>>>>> icons-toolbar.properties and icon.properties ? >>>>>>> >>>>>>> We already have a lot of properties. >>>>>>> >>>>>>> -- >>>>>>> Cordialement. >>>>>>> Philippe Mouawad. >>>>>>> >>>>>> >>>>> >>>>> -- >>>>> Cordialement. >>>>> Philippe Mouawad. >>>>> >>>>> >>>>> >>>>> >>>> -- >>>> Cordialement. >>>> Philippe Mouawad. >>>> >>> >> >> > -- Cordialement. Philippe Mouawad. --001a11488a78d89ffd052f0d208c--