Return-Path: 
 <dev-return-6118-apmail-jmeter-dev-archive=jmeter.apache.org@jmeter.apache.org>
X-Original-To: apmail-jmeter-dev-archive@minotaur.apache.org
Delivered-To: apmail-jmeter-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2965918478
	for <apmail-jmeter-dev-archive@minotaur.apache.org>;
 Mon, 28 Mar 2016 10:28:24 +0000 (UTC)
Received: (qmail 17909 invoked by uid 500); 28 Mar 2016 10:28:24 -0000
Delivered-To: apmail-jmeter-dev-archive@jmeter.apache.org
Received: (qmail 17883 invoked by uid 500); 28 Mar 2016 10:28:24 -0000
Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@jmeter.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@jmeter.apache.org>
List-Post: <mailto:dev@jmeter.apache.org>
List-Id: <dev.jmeter.apache.org>
Reply-To: dev@jmeter.apache.org
Delivered-To: mailing list dev@jmeter.apache.org
Received: (qmail 17748 invoked by uid 99); 28 Mar 2016 10:28:23 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Mar 2016 10:28:23 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 6FDB8DFDEC; Mon, 28 Mar 2016 10:28:23 +0000 (UTC)
From: ham1 <git@git.apache.org>
To: dev@jmeter.apache.org
Reply-To: dev@jmeter.apache.org
References: <git-pr-174-jmeter@git.apache.org>
In-Reply-To: <git-pr-174-jmeter@git.apache.org>
Subject: [GitHub] jmeter pull request: Used multi-catch, enhanced for loops,
 contain...
Content-Type: text/plain
Message-Id: <20160328102823.6FDB8DFDEC@git1-us-west.apache.org>
Date: Mon, 28 Mar 2016 10:28:23 +0000 (UTC)

Github user ham1 commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/174#discussion_r57560546
  
    --- Diff: test/src/org/apache/jmeter/resources/PackageTest.java ---
    @@ -136,9 +136,9 @@ private int readRF(String res, List<String> l) throws Exception {
                          * parameters and check if there is a { in the output. A bit
                          * crude, but should be enough for now.
                          */
    -                    if (val.indexOf("{0}") > 0 && val.indexOf('\'') > 0) {
    +                    if (val.contains("{0}") && val.contains("'")) {
    --- End diff --
    
    This change isn't exactly the same as the existing code, however it matches the comment, I think the > instead of >= in the original was a mistake.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---