jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: svn commit: r1734632 - in /jmeter/trunk: src/components/org/apache/jmeter/control/ModuleController.java xdocs/changes.xml
Date Sat, 12 Mar 2016 13:28:37 GMT
I don't know.
For me the test is broken anyway so why wait more than necessary, that's
why I chose JMeterStopTestNowException.
As a user I prefer not to lose time waiting for a failed test.
I am always in a hurry usually so any second I gain is fine for me.

On Sat, Mar 12, 2016 at 2:25 PM, sebb <sebbaz@gmail.com> wrote:

> Not sure it needs JMeterStopTestNowException - immediate stop.
> I think it would it be better to use the JMeterStopTestException, i.e.
> let active samplers complete.
>
> On 11 March 2016 at 21:11,  <pmouawad@apache.org> wrote:
> > Author: pmouawad
> > Date: Fri Mar 11 21:11:18 2016
> > New Revision: 1734632
> >
> > URL: http://svn.apache.org/viewvc?rev=1734632&view=rev
> > Log:
> > Bug 59076 - Test should fail if a module controller cannot find its
> replacement subtree
> > Bugzilla Id: 59076
> >
> > Modified:
> >
>  jmeter/trunk/src/components/org/apache/jmeter/control/ModuleController.java
> >     jmeter/trunk/xdocs/changes.xml
> >
> > Modified:
> jmeter/trunk/src/components/org/apache/jmeter/control/ModuleController.java
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/control/ModuleController.java?rev=1734632&r1=1734631&r2=1734632&view=diff
> >
> ==============================================================================
> > ---
> jmeter/trunk/src/components/org/apache/jmeter/control/ModuleController.java
> (original)
> > +++
> jmeter/trunk/src/components/org/apache/jmeter/control/ModuleController.java
> Fri Mar 11 21:11:18 2016
> > @@ -32,6 +32,7 @@ import org.apache.jmeter.testelement.pro
> >  import org.apache.jmeter.testelement.property.NullProperty;
> >  import org.apache.jorphan.collections.HashTree;
> >  import org.apache.jorphan.collections.ListedHashTree;
> > +import org.apache.jorphan.util.JMeterStopTestNowException;
> >
> >  /**
> >   * The goal of ModuleController is to add modularity to JMeter. The
> general idea
> > @@ -136,6 +137,10 @@ public class ModuleController extends Ge
> >              if (nodePathList != null && nodePathList.size() > 0) {
> >                  traverse(context, nodePathList, 1);
> >              }
> > +
> > +            if(isRunningVersion() && selectedNode == null) {
> > +                throw new
> JMeterStopTestNowException("ModuleController:"+getName()+" has no selected
> Controller, test was stopped as a consequence");
> > +            }
> >          }
> >      }
> >
> >
> > Modified: jmeter/trunk/xdocs/changes.xml
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1734632&r1=1734631&r2=1734632&view=diff
> >
> ==============================================================================
> > --- jmeter/trunk/xdocs/changes.xml (original)
> > +++ jmeter/trunk/xdocs/changes.xml Fri Mar 11 21:11:18 2016
> > @@ -341,6 +341,7 @@ Summary
> >      <li><bug>58678</bug>Module Controller : limit target element
> selection. Contributed by Benoit Wiart (benoit dot wiart at gmail.com
> )</li>
> >      <li><bug>58714</bug>Module controller : it should not be
possible
> to add a timer as child. Contributed by Benoit Wiart (benoit dot wiart at
> gmail.com)</li>
> >      <li><bug>59067</bug>JMeter fails to iterate over Controllers
that
> are children of a TransactionController having "Generate parent sample"
> checked after an assertion error occurs on a Thread Group with "Start Next
> Thread Loop". Contributed by Benoit Wiart(benoit dot wiart at gmail.com
> )</li>
> > +    <li><bug>59076</bug>Test should fail if a module controller
cannot
> find its replacement subtree</li>
> >  </ul>
> >
> >  <h3>Listeners</h3>
> >
> >
>



-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message