jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ham1 <...@git.apache.org>
Subject [GitHub] jmeter pull request: Used multi-catch, enhanced for loops, contain...
Date Mon, 28 Mar 2016 10:28:23 GMT
Github user ham1 commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/174#discussion_r57560546
  
    --- Diff: test/src/org/apache/jmeter/resources/PackageTest.java ---
    @@ -136,9 +136,9 @@ private int readRF(String res, List<String> l) throws Exception
{
                          * parameters and check if there is a { in the output. A bit
                          * crude, but should be enough for now.
                          */
    -                    if (val.indexOf("{0}") > 0 && val.indexOf('\'') > 0)
{
    +                    if (val.contains("{0}") && val.contains("'")) {
    --- End diff --
    
    This change isn't exactly the same as the existing code, however it matches the comment,
I think the > instead of >= in the original was a mistake.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message