Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CAH9fUpY8gnUc_Db+wFHVt6w2mBT4-tAymJ5bfFtK1_61oONt_w@mail.gmail.com>
References: 
 <CAOGo0VaF8VBXyJpzFWOR+FNG5X+-YUjOqxt5fwdmGnvS3pUTuw@mail.gmail.com>
	<CAB=Je-Hw5m=b6LH0YWDJvL7e2x5Pphgh-YRvPhZtqa1Y8UDq8A@mail.gmail.com>
	<CAOGo0VYYLsRHGf2DB3C55WuGyQMbmAXYhR-FrdT4bXfx1SNobA@mail.gmail.com>
	<CAB=Je-EAFMK-gLQr_KQre1QWVuzLtOEP3SU2fg20OQo6jpg7HA@mail.gmail.com>
	<CAH9fUpY8gnUc_Db+wFHVt6w2mBT4-tAymJ5bfFtK1_61oONt_w@mail.gmail.com>
Date: Thu, 4 Feb 2016 20:58:25 +0000
Message-ID: 
 <CAOGo0VZaS5KQM6=cVX7TELGWv5kxoXv=gLYFK36SShtkEVTQ1A@mail.gmail.com>
Subject: Re: Tabs in source files are not allowed
From: sebb <sebbaz@gmail.com>
To: dev@jmeter.apache.org
Content-Type: text/plain; charset=UTF-8

On 4 February 2016 at 20:42, Philippe Mouawad
<philippe.mouawad@gmail.com> wrote:
> @sebb, I am responsible if this commit, I was going to fix it  this evening
> but you did it before, thanks.
>
> I think:
>
>    -  we should highlight somewhere

Feel free, but I'm not sure where to record this.

>    - or/and add "checkstyle"  to "package" ant task  so that builld fails

I wondered about this, but it increases the build time considerably.
Perhaps it could be moved to the start of the test phase?
However that itself takes a long time and there is also no guarantee
that committers run the test before committing.

>    - or/and follow Vladimir's proposal.

That's fine, but it's quite a bit of work to do, and it won't help
with SVN commits or non-Git patches.

>
> Anyway, my strategy is the following:
>
>    - I prefer a contribution that improves the product even if it contains
>    tab spaces. Now that you created the check it is easy to find so it is a
>    little problem.

If a patch contains a few tabs I'll fix them myself and ask the
provider to remove them from any future patches.
Just as we would with missing AL headers etc.

>
>
>
> On Thu, Feb 4, 2016 at 4:50 PM, Vladimir Sitnikov <
> sitnikov.vladimir@gmail.com> wrote:
>
>> >However Travis and Jenkins are run on the checked-in source - it's
>> >already too late.
>>
>> Can Jenkins be integrated with Github PRs? It could be possible.
>>
>> Travis can definitely check at the pull request level.
>> It is extremely useful for those who provide Github PRs. Even if the
>> patch has to be converted to bugzilla later.
>>
>> Codecov.io can track code coverage (that is it tracks if pull request
>> adds a sampler that is not covered by the unit tests).
>>
>> Here's an example:
>> https://github.com/pgjdbc/pgjdbc/pull/493#issuecomment-172622681
>>
>> Vladimir
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.