jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benbenw <...@git.apache.org>
Subject [GitHub] jmeter pull request: Bug 52073 Embedded Resources concurrent downl...
Date Fri, 19 Feb 2016 16:04:07 GMT
GitHub user benbenw opened a pull request:

    https://github.com/apache/jmeter/pull/132

    Bug 52073 Embedded Resources concurrent download : Improve performances by avoiding shutdown
of ThreadPoolExecutor at each sample.

    Please test and review carefully
    
    A shared thread pool is used for all the parallel downloads.
    A throttle mechanism is used per user to ensure the max concurrent
    downloads setting is not exceeded.
    A new parameter httpsampler.parallel_download_thread_keepalive_inseconds
    is used to set the thread TTL when idle (default 60s).
    the parameter httpsampler.await_termination_timeout is not used anymore
    and has been removed.
    
    TODO : ResourcesDownloader#shrink should be called at the end of a test
    to accelerate the release of the thread pool idle threads (not
    mandatory)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benbenw/jmeter resourcedownloader

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #132
    
----
commit 367b677c3f22b9693ceed4223a36ceba02235b87
Author: benoit <b.wiart@ubik-ingenierie.com>
Date:   2016-02-19T15:49:49Z

    Bug 52073 Embedded Resources concurrent download : Improve performances
    by avoiding shutdown of ThreadPoolExecutor at each sample.
    A shared thread pool is used for all the parallel downloads.
    A throttle mechanism is used per user to ensure the max concurrent
    downloads setting is not exceeded.
    A new parameter httpsampler.parallel_download_thread_keepalive_inseconds
    is used to set the thread TTL when idle (default 60s).
    the parameter httpsampler.await_termination_timeout is not used anymore
    and has been removed.
    
    TODO : ResourcesDownloader#shrink should be called at the end of a test
    to accelerate the release of the thread pool idle threads (not
    mandatory)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message