jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmouawad <...@git.apache.org>
Subject [GitHub] jmeter pull request: Refactored addKeyData in AbstractGraphConsume...
Date Thu, 18 Feb 2016 13:44:10 GMT
Github user pmouawad commented on the pull request:

    https://github.com/apache/jmeter/pull/129#issuecomment-185728403
  
    Hello,
    I think there is an issue with your refactoring of AbstractGraphConsumer.
    at lines 341 to 351, you have refactored the Map iteration but:
    1) One contains:
    `
                        coordResult.addResult(new ValueResultData(
                                Double.valueOf(percentile)));
                        coordResult.addResult(new ValueResultData(value));
    `
    2/ The other one contains:
    
    `coordResult.addResult(new ValueResultData(value));
                            coordResult.addResult(new ValueResultData(
                                    Double.valueOf(percentile)));`
    
    
    So unless I am missing something I don't think it is ok.
    
    Besides, I prefer not to mix formatting with refactoring.
    I will only include formatting from this PR.
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message