Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
Message-ID: <1451468581.20141.10.camel@apache.org>
Subject: Re: About SNI support in HC4.5
From: Oleg Kalnichevski <olegk@apache.org>
To: HttpClient User Discussion <httpclient-users@hc.apache.org>
Cc: "dev@jmeter.apache.org" <dev@jmeter.apache.org>
Date: Wed, 30 Dec 2015 10:43:01 +0100
In-Reply-To: 
 <CAH9fUpaiYrqPOQUFLj57vGRzLpNY6oUqpJf_n3rLL4_ADZAxJA@mail.gmail.com>
References: 
	<CAH9fUpZgVepmS3Y=7ogsWYsOFtm5yAfDxkuohd2N2ZabCWi=hQ@mail.gmail.com>
	 <CAH9fUpbOC5-J_5dYCgJ5s7z+2X9wof5JZ+aVoDmOVyjmcexXCg@mail.gmail.com>
	 <CAH9fUpby-WyiMnya5wAihK+C6u8QLrz9O0bBn41ecUCyKEAeYQ@mail.gmail.com>
	 <1450877979.7429.2.camel@apache.org>
	 <CAH9fUpaiYrqPOQUFLj57vGRzLpNY6oUqpJf_n3rLL4_ADZAxJA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

On Tue, 2015-12-29 at 09:22 +0100, Philippe Mouawad wrote:
> Hello Oleg,
> Thanks for answer.
> Could you elaborate a bit more on your answer ?
> 
> Also, is there a chance that you fix the issue also in deprecated code of
> httpclient (org.apache.http.conn.ssl.SSLSocketFactory) or is it too complex
> ?
> 

I personally see no point in fixing non-critical bugs in deprecated
code. This time can be better spent elsewhere. However I can commit a
fix though if contributed.

Oleg


> Thanks
> 
> On Wednesday, December 23, 2015, Oleg Kalnichevski <olegk@apache.org> wrote:
> 
> > On Wed, 2015-12-23 at 14:30 +0100, Philippe Mouawad wrote:
> > > Hi,
> > > Any answer on the 1/ question ?
> > > Thanks
> > > Regards
> > >
> > > On Tue, Dec 22, 2015 at 2:39 PM, Philippe Mouawad <
> > > philippe.mouawad@gmail.com <javascript:;>> wrote:
> > >
> > > > Hi,
> > > > With further investigation, I answered to some of my questions.
> > > >
> > > > Regards
> > > >
> > > > On Mon, Dec 21, 2015 at 6:52 PM, Philippe Mouawad <
> > > > philippe.mouawad@gmail.com <javascript:;>> wrote:
> > > >
> > > >> Hello,
> > > >> Looking at:
> > > >>
> > > >>    - https://issues.apache.org/jira/browse/HTTPCLIENT-1119
> > > >>
> > > >>
> > > >> 1/ It is not clear for me how the fix works if commit association is
> > > >> correct:
> > > >>
> > > >>    -
> > https://fisheye6.atlassian.com/changelog/httpcomponents?cs=1544769
> > > >>
> > > >> Is the fix about replacing:
> > > >>
> > > >> final SSLSocket sock = (SSLSocket) this.socketfactory.createSocket();
> > > >>
> > > >> with :
> > > >> SocketFactory.getDefault().createSocket();
> >
> > Pretty much. Please note though that the use of a plain socket instead
> > of a fully initialized SSL socket causes a different execution path in
> > #connectSocket method.
> >
> > Oleg
> >
> >
> >
> >
>