Return-Path: X-Original-To: apmail-jmeter-dev-archive@minotaur.apache.org Delivered-To: apmail-jmeter-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2AE2618BF6 for ; Sun, 2 Aug 2015 18:53:24 +0000 (UTC) Received: (qmail 4812 invoked by uid 500); 2 Aug 2015 18:53:23 -0000 Delivered-To: apmail-jmeter-dev-archive@jmeter.apache.org Received: (qmail 4784 invoked by uid 500); 2 Aug 2015 18:53:23 -0000 Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jmeter.apache.org Delivered-To: mailing list dev@jmeter.apache.org Received: (qmail 4771 invoked by uid 99); 2 Aug 2015 18:53:23 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Aug 2015 18:53:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2F153D9ABD for ; Sun, 2 Aug 2015 18:53:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.898 X-Spam-Level: ** X-Spam-Status: No, score=2.898 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id tCBbXv6Xmq51 for ; Sun, 2 Aug 2015 18:53:22 +0000 (UTC) Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com [209.85.213.171]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTPS id 3269C43818 for ; Sun, 2 Aug 2015 18:53:22 +0000 (UTC) Received: by igbpg9 with SMTP id pg9so44024873igb.0 for ; Sun, 02 Aug 2015 11:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=ayApeZGrKCekXD/PoOAhtETQ+2BWOlrVRWnIuuCJS50=; b=sZKOyv1b7zqrNJjfSm4gvi8bhcrgHdhCljz1S9BGz1F85RKBsWpWkfEYzd8xUvTcmh QMTSt5gQ8PE5WdjwPM2LVcAQxsO9oKkmtoFXIg9FnX35yKQes9jpT946Yo6mAjm8ghXB 3sHwKiwa445eaoFvQO1J30rL+Ga6/wCe0t7f7+DFhdmWiquCUpAtYMfsR44UQTMnaOaZ M9ftNpKrnlks/ilejCJXj2sxQRzPvJs/NDnjX3Fi0DjRmNFEMCzdt1d317ZsFGyFvmtR Oi2znsTtmKvnsLuj0Hfa2jz8w5ew71wTQPOfrTacoOJBAB2x04wlpurxehJVMAHtT+ey VikA== MIME-Version: 1.0 X-Received: by 10.50.41.67 with SMTP id d3mr17829913igl.57.1438541596072; Sun, 02 Aug 2015 11:53:16 -0700 (PDT) Received: by 10.107.130.31 with HTTP; Sun, 2 Aug 2015 11:53:16 -0700 (PDT) In-Reply-To: <55BE2564.3040906@apache.org> References: <20150802135319.5A2D5AC009B@hades.apache.org> <55BE2564.3040906@apache.org> Date: Sun, 2 Aug 2015 20:53:16 +0200 Message-ID: Subject: Re: svn commit: r1693815 - /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java From: Philippe Mouawad To: "dev@jmeter.apache.org" Content-Type: multipart/alternative; boundary=089e0112d054d42497051c5890a0 --089e0112d054d42497051c5890a0 Content-Type: text/plain; charset=UTF-8 Thanks Felix, nice fix On Sunday, August 2, 2015, Milamber wrote: > Thanks Felix to fix up the issue! > > On 02/08/2015 14:53, fschumacher@apache.org wrote: > >> Author: fschumacher >> Date: Sun Aug 2 13:53:18 2015 >> New Revision: 1693815 >> >> URL: http://svn.apache.org/r1693815 >> Log: >> Bug 58137: Warn about urls that had to be escaped. >> Bugzilla Id: 58137 >> >> Modified: >> >> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java >> >> Modified: >> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java >> URL: >> http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1693815&r1=1693814&r2=1693815&view=diff >> >> ============================================================================== >> --- >> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java >> (original) >> +++ >> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java >> Sun Aug 2 13:53:18 2015 >> @@ -1361,8 +1361,9 @@ public abstract class HTTPSamplerBase ex >> } >> try { >> String escapedUrl = >> ConversionUtils.escapeIllegalURLCharacters(url); >> - if(log.isDebugEnabled()) { >> - log.debug("Successfully escaped url:'"+url +"' >> to:'"+escapedUrl+"'"); >> + if (!escapedUrl.equals(url)) { >> + log.warn("Url '" + url + "' has been escaped to '" + >> escapedUrl >> + + "'. Please corect your webpage."); >> } >> return escapedUrl; >> } catch (Exception e1) { >> >> >> >> > -- Cordialement. Philippe Mouawad. --089e0112d054d42497051c5890a0--