jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Schumacher <felix.schumac...@internetallee.de>
Subject Re: svn commit: r1692251 - /jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/protocol/SendMailCommand.java
Date Thu, 23 Jul 2015 12:19:15 GMT


Am 23. Juli 2015 14:16:12 MESZ, schrieb sebb <sebbaz@gmail.com>:
>On 22 July 2015 at 11:42,  <fschumacher@apache.org> wrote:
>> Author: fschumacher
>> Date: Wed Jul 22 10:42:40 2015
>> New Revision: 1692251
>>
>> URL: http://svn.apache.org/r1692251
>> Log:
>> Bug 58013 - Constants for ssl protocols differ for smtp and smtp.
>
>Please add bug details to changes.xml

The overall bug did not change. It was meant for all mail protocols and there was no official
release on between. 

Is it really necessary? 

In my eyes this change is a Bugfix for the Bugfix.

But I will look at the exact wording of the current entry. 

Regards, 
Felix 
>
>> Bugzilla Id: 58013
>>
>> Modified:
>>    
>jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/protocol/SendMailCommand.java
>>
>> Modified:
>jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/protocol/SendMailCommand.java
>> URL:
>http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/protocol/SendMailCommand.java?rev=1692251&r1=1692250&r2=1692251&view=diff
>>
>==============================================================================
>> ---
>jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/protocol/SendMailCommand.java
>(original)
>> +++
>jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/protocol/SendMailCommand.java
>Wed Jul 22 10:42:40 2015
>> @@ -144,7 +144,7 @@ public class SendMailCommand {
>>                  String allProtocols = StringUtils.join(
>>                     
>SSLContext.getDefault().getSupportedSSLParameters().getProtocols(), "
>");
>>                  logger.info("Use ssl/tls protocols for mail: " +
>allProtocols);
>> -                props.setProperty("mail.smtp.ssl.protocols",
>allProtocols);
>> +                props.setProperty("mail." + protocol +
>".ssl.protocols", allProtocols);
>>              } catch (Exception e) {
>>                  logger.error("Problem setting ssl/tls protocols for
>mail", e);
>>              }
>>
>>


Mime
View raw message