jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrey Pokhilko <a...@ya.ru>
Subject Re: Component adding hotkeys
Date Mon, 08 Jun 2015 13:04:54 GMT
Tried on my colleague's Windows 7 laptop, all keys except Ctrl+6 do
work, the latter shows "gui.quick_null" warning. I wonder why Ctrl+6 is
so special...

Andrey Pokhilko

On 06/07/2015 05:53 PM, Andrey Pokhilko wrote:
> Tried on my colleague's mac, works as Command+0 .. Command+9 flawlessly.
>
> java version "1.8.0_31"
> Darwin MacBook-Pro.local 14.3.0 Darwin Kernel Version 14.3.0: Mon Mar 23
> 11:59:05 PDT 2015; root:xnu-2782.20.48~5/RELEASE_X86_64 x86_64
>
> Andrey Pokhilko
>
> On 06/06/2015 12:06 AM, Philippe Mouawad wrote:
>> Hello,
>> I started testing this evening and I have an issue, on Mac Book pro there
>> is no numeric keypad.
>> So I had to change the properties to this and it works:
>> gui.quick_à=ThreadGroupGui
>> gui.quick_&=HttpTestSampleGui
>> gui.quick_é=RegexExtractorGui
>> gui.quick_"=AssertionGui
>> gui.quick_'=ConstantTimerGui
>> gui.quick_(=TestActionGui
>> gui.quick_§=JSR223PostProcessor
>> gui.quick_è=JSR223PreProcessor
>> gui.quick_!=DebugSampler
>> gui.quick_ç=ViewResultsFullVisualizer
>>
>>
>> Is there a better way on Mac Book Pro ?
>> Regards
>>
>> On Wed, Jun 3, 2015 at 1:17 PM, Andrey Pokhilko <apc4@ya.ru> wrote:
>>
>>> "Most used" depends on every user. I believe first keys 1-5 will be most
>>> used and we already set them fine. I have just committed it into SVN, it
>>> is your right to change everything as you see it :) I set it like I see it.
>>>
>>> Andrey Pokhilko
>>>
>>> On 06/03/2015 01:19 PM, Philippe Mouawad wrote:
>>>> On Wed, Jun 3, 2015 at 8:54 AM, Andrey Pokhilko <apc4@ya.ru
>>>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru');>> wrote:
>>>>
>>>>> Not having a Thread Group in hotkeys disbles "fluent start", when you
>>>>> just opened JMeter and immediately start building Test Plan with
>>>>> hotkeys. My UX feeling says that we should still have it. Ctrl+0 is the
>>>>> most rightsided key, that reflects rarity of usage.
>>>>>
>>>> Agreed
>>>>
>>>>> Having Debug Sampler and View Results Tree also required UX-wise,
>>>>> because you need them not frequently, but always urgently when you want
>>>>> to troubleshoot your script and instant usage will gratify hurrying
>>> user.
>>>> But not having CSS/JQuery extractor is not a good thing, In our scripting
>>>> experience it is among the top 5 elements used.
>>>> Although new element it is great for html extraction and makes tests more
>>>> maintainable
>>>>
>>>>> Finally, user can always set up his preferred keys to reflect his style
>>>>> of usage.
>>>>>
>>>> But hotkeys should reflect most used components.
>>>>
>>>>> Andrey Pokhilko
>>>>>
>>>>> On 06/03/2015 03:34 AM, sebb wrote:
>>>>>> On 2 June 2015 at 20:42, Philippe Mouawad <philippe.mouawad@gmail.com
>>>>> <javascript:_e(%7B%7D,'cvml','philippe.mouawad@gmail.com');>>
wrote:
>>>>>>> Hi,
>>>>>>> Thanks for taking into account some notes.
>>>>>>>
>>>>>>> 1/ I would put these defaults:
>>>>>>> gui.quick_0=ThreadGroupGui
>>>>>> Although that is needed for every test, often only one is needed.
>>>>>> It seems wasteful to use up a quick key for this.
>>>>>>
>>>>>> Maybe a ThreadGroup should be automatically added to a new test plan.
>>>>>> Or a template added that includes a ThreadGroup (possibly plus a
>>>>>> Listener at plan level), and make that the default.
>>>>>>
>>>>>>> gui.quick_1=HttpTestSampleGui
>>>>>>> gui.quick_2=RegexExtractorGui
>>>>>>> gui.quick_3=HtmlExtractorGui
>>>>>>> gui.quick_4=AssertionGui
>>>>>>> gui.quick_5=ConstantTimerGui
>>>>>>> gui.quick_6=GaussianRandomTimerGui
>>>>>>> gui.quick_7=TestActionGui
>>>>>>> gui.quick_8=JSR223PostProcessor
>>>>>>> gui.quick_9=JSR223PreProcessor
>>>>>>>
>>>>>>>
>>>>>>> As for me DebugSampler is not added very frequently, same for
>>>>>>> ViewResultsTree.
>>>>>> I tend to use ViewResultsTree a lot, but again usually only one is
>>>>> needed.
>>>>>>> 2/ Is it  a good thing to try to add element somewhere in the
tree
>>>>>>> hierarchy ? I would fail if current node does not allow it.
>>>>>>>
>>>>>>> Regards
>>>>>>>
>>>>>>> On Tue, Jun 2, 2015 at 12:46 PM, Andrey Pokhilko <apc4@ya.ru
>>>>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru');>> wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> I fixed issue with Ctrl+9, changed defaults slightly, added
doc and
>>>>>>>> bugzilla https://bz.apache.org/bugzilla/show_bug.cgi?id=57988
>>>>>>>>
>>>>>>>> If there are no objections, I will commit this change within
24
>>> hours.
>>>>>>>> Andrey Pokhilko
>>>>>>>>
>>>>>>>> On 04/30/2015 03:49 PM, Philippe Mouawad wrote:
>>>>>>>>> Hi,
>>>>>>>>> I think it's a nice idea, we have same the same feedback.
>>>>>>>>>
>>>>>>>>> For me it should be in core once linux issue is fixed,
what about
>>>>> tested
>>>>>>>>> platforms:
>>>>>>>>> - Windows 8? 7 ?
>>>>>>>>> - Linux
>>>>>>>>> - Mac OSX ? which os ?
>>>>>>>>>
>>>>>>>>> Regarding other questions, answers inline.
>>>>>>>>>
>>>>>>>>> Regards
>>>>>>>>> On Monday, April 27, 2015, Andrey Pokhilko <apc4@ya.ru
>>>>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru');>
>>>>>>>>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru
>>>>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru');>');>> wrote:
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> I have colleagues that do heavy JMeter scripting
and they come with
>>>>> idea
>>>>>>>>>> to speed-up the process: have hotkeys to add JMeter
components to
>>>>> test
>>>>>>>>>> plan. Using a hotkey eliminates the need to walk
through context
>>>>> menus.
>>>>>>>>>> As always, Pareto principle states that 80% of a
time people use
>>> 20%
>>>>> of
>>>>>>>>>> components, so small set of hotkeys would cover most
of situations.
>>>>>>>>>>
>>>>>>>>>> I have implemented this feature as Ctrl+0 .. Ctrl+9
hotkey set,
>>> with
>>>>>>>>>> components configurable through properties. Components
are added
>>> as a
>>>>>>>>>> child of current position, if possible, or a sibling
at the nearest
>>>>>>>>>> possible scope. I provided my colleagues with patched
JMeter and
>>> they
>>>>>>>>>> found the feature working smoothly.
>>>>>>>>>>
>>>>>>>>>> Pull request for easy review is here:
>>>>>>>>>> https://github.com/apache/jmeter/pull/16 , I will
create bugzilla
>>>>> for
>>>>>>>>>> this when needed.
>>>>>>>>>>
>>>>>>>>>> As always I ask if other committers support adding
this into main
>>>>> JMeter
>>>>>>>>>> codebase or not.
>>>>>>>>>>
>>>>>>>>>> Some notes/questions from my side:
>>>>>>>>>>
>>>>>>>>>>   * Where is appropriate place in the docs to document
this
>>> feature?
>>>>>>>>> Somewhere where Search Feature and templates are documented
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>   * Are defaults good? What are most used JMeter
components?
>>>>>>>>> I would remove or put them at end:
>>>>>>>>> View Results Tree
>>>>>>>>> User Defined Variables
>>>>>>>>> Test Fragment
>>>>>>>>>
>>>>>>>>> as although popular you rarely add more than 2 or 3.
>>>>>>>>>
>>>>>>>>> I would add :
>>>>>>>>> - Css/JQuery extractor
>>>>>>>>> - Jsr223 Post processor
>>>>>>>>> - Test Action for the timer discussion we had
>>>>>>>>> - JSR223 Pre processir
>>>>>>>>> -Debug Sampler
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>   * Is there a way to specify component names in
properties instead
>>>>> of
>>>>>>>>>>     classes?
>>>>>>>>> There are name shortcuts in saveservice.properties
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>   * On my Linux Ctrl+9 does not work for some reason...
I wonder if
>>>>>>>>>>     somebody knows why.
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Andrey Pokhilko
>>>>>>>>>>
>>>>>>>>>>
>>>>>>> --
>>>>>>> Cordialement.
>>>>>>> Philippe Mouawad.


Mime
View raw message