Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
Message-ID: <1432616750.32566.25.camel@cat>
Subject: Re: Github comments on dev mailing-list | Fwd: [GitHub] jmeter pull
 request: Extended JMSSampler
From: Felix Schumacher <felix.schumacher@internetallee.de>
To: dev@jmeter.apache.org
Date: Tue, 26 May 2015 07:05:50 +0200
In-Reply-To: <555F56D7.6070405@apache.org>
References: <git-pr-17-jmeter@git.apache.org> <555F56D7.6070405@apache.org>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

Am Freitag, den 22.05.2015, 17:18 +0100 schrieb Milamber:
> Hello
> 
> Philippe has post a comment to Anitka on Github for this pull request, 
> but we don't receive a copy on mailing-list. On the Cloudstack project 
> we receive an email for each comments (and for the close message) on the 
> Github clone project.
> 
> I think that's a good thing to follow the PR lifecycle on the dev 
> mailing list directly.
> 
> If you are agreed, I can find the way to do this.
+1

I would like to be informed on any updates from the github repository.

Regards
 Felix

> 
> Milamber
> 
> -------- Forwarded Message --------
> Subject: 	[GitHub] jmeter pull request: Extended JMSSampler
> Date: 	Wed, 20 May 2015 19:45:20 +0000 (UTC)
> From: 	Anitka <git@git.apache.org>
> Reply-To: 	dev@jmeter.apache.org, dev@jmeter.apache.org
> To: 	dev@jmeter.apache.org
> 
> 
> 
> GitHub user Anitka opened a pull request:
> 
>      https://github.com/apache/jmeter/pull/17
> 
>      Extended JMSSampler
> 
>      I extended the JMSSampler as when we use byte messages then it is impossible to e.g. make any assertions (all of them fail). I added a case when message is byte message and then I converted it to string. Then assertions work as it is expected.
> 
> You can merge this pull request into a Git repository by running:
> 
>      $ git pull https://github.com/Anitka/jmeter trunk
> 
> Alternatively you can review and apply these changes as the patch at:
> 
>      https://github.com/apache/jmeter/pull/17.patch
> 
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> 
>      This closes #17
>      
> ----
> commit b85089e7e0ccbc8cd63723931172bcb131936853
> Author: Anita Ciosek <anita.ciosek@sabre.com>
> Date:   2015-05-20T19:37:59Z
> 
>      Extended JMSSampler
> 
> ----
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>