jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: Possible NPE in converters
Date Mon, 22 Dec 2014 16:57:42 GMT
On 22 December 2014 at 16:34, Felix Schumacher
<felix.schumacher@internetallee.de> wrote:
> Hi all,
>
> in the converters in org.apache.jmeter.save.converters there are a few
> possible NPE. In the method canConvert(Class) often the implementation looks
> like
>
>  "return arg0.equals(SomeClass.class)"
>
> without arg0 being checked for non-null.
>
> I have a patch, that reverts the logic to
>
>  "return SomeClass.class.equals(arg0)"
>
> This is null safe and should return the same values (apart from possible
> NPE).
>
> Can I check those changes in whithout creating a bugzilla entry?

OK by me.

Please ensure that the commit only contains these specific changes,
and not any unrelated ones.
Thanks.

> Regards
>  Felix

Mime
View raw message