jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: Why do Functions that only have values as instance variable synchronize execute ?
Date Sun, 19 Oct 2014 21:21:16 GMT
Hi,
One other note regarding a comment you put in code of Random.java regarding
the use of ThreadLocalRandom:
- https://issues.apache.org/bugzilla/show_bug.cgi?id=54453

Unfortunately my tests don't show performance improvement after adding it.

This disturbs me

Regards

On Sun, Oct 19, 2014 at 9:42 PM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:

> Hello Vladimir,
> Thanks for contribution.
> For 2, 3 you can open a bugzilla and attach patch.
>
>
> I reviewed the patch, look OK for me, but why don't you also synchronize
> LogFunction2#execute since you do for LogFunction#execute ?
>
> Thanks
>
> On Sat, Oct 18, 2014 at 4:44 PM, Vladimir Sitnikov <
> sitnikov.vladimir@gmail.com> wrote:
>
>> Thanks for creating a bug id. I've attached the patch.
>>
>> What is the preferred way to handle small improvements like 2 and 3?
>>
>> Vladimir Sitnikov
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>


-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message